Fix QuarkusMainLauncher not returning exit code
#42252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Let's get CI running and see how it goes. We definitely need this for 3.13.1. |
|
Thanks a lot for this! I presume the commit history can be improved on this one |
This comment has been minimized.
This comment has been minimized.
`QuarkusMainLauncher` always returns `0`, because `currentApplication` is set to `null` in `io.quarkus.runtime.ApplicationLifecycleManager#run(io.quarkus.runtime.Application, java.lang.Class<? extends io.quarkus.runtime.QuarkusApplication>, java.util.function.BiConsumer<java.lang.Integer,java.lang.Throwable>, java.lang.String...)`. This change introduces a new callback to `ApplicationLifecycleManager` used by `StartupActionImpl` to know whether the application was actually started or not.
gsmet
approved these changes
Aug 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
QuarkusMainLauncheralways returns0, becausecurrentApplicationis set tonullinio.quarkus.runtime.ApplicationLifecycleManager#run(io.quarkus.runtime.Application, java.lang.Class<? extends io.quarkus.runtime.QuarkusApplication>, java.util.function.BiConsumer<java.lang.Integer,java.lang.Throwable>, java.lang.String...).This change introduces a new callback to
ApplicationLifecycleManagerused byStartupActionImplto know whether the application was actually started or not.QuarkusMainLauncheralways returns exit code 0 for integration tests #42250