Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Testing/3.13.0: QuarkusMainLauncher always returns exit code 0 for integration tests #42250

Closed
snazy opened this issue Jul 31, 2024 · 0 comments · Fixed by #42252
Closed

Testing/3.13.0: QuarkusMainLauncher always returns exit code 0 for integration tests #42250

snazy opened this issue Jul 31, 2024 · 0 comments · Fixed by #42252
Assignees
@gsmet
Labels
area/core kind/bug Something isn't working
Milestone
3.13.1

Comments

@snazy
Copy link
Contributor

snazy commented Jul 31, 2024 •
edited
Loading

Describe the bug

Since Quarkus 3.13.0, QuarkusMainLauncher always returns exit code 0 for integration tests and not the actual exit code.

Expected behavior

No response

Actual behavior

Looks like this change via #41726 made QuarkusMainLauncher always return exit code 0, because of this check in StartupActionImpl.runMainClassBlocking()

/cc @gsmet

How to Reproduce?

No response

Output of uname -a or ver

No response

Output of java -version

No response

Quarkus version or git rev

3.13.0

Build tool (ie. output of mvnw --version or gradlew --version)

No response

Additional information

No response
@snazy snazy added the kind/bug Something isn't working label Jul 31, 2024
@gsmet gsmet self-assigned this Jul 31, 2024
@snazy snazy changed the title Testing/3.13.0: QuarkusMainLauncher always returns exit code 0 Testing/3.13.0: QuarkusMainLauncher always returns exit code 0 for integration tests Jul 31, 2024
This was referenced Jul 31, 2024
Closed
Merged
Merged
@quarkus-bot quarkus-bot bot added this to the 3.14 - main milestone Aug 1, 2024
@gsmet gsmet modified the milestones: 3.14 - main, 3.13.1 Aug 1, 2024
@goldmann goldmann mentioned this issue Aug 9, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gsmet gsmet

Labels
area/core kind/bug Something isn't working
Projects
None yet
Milestone
3.13.1
Development

Successfully merging a pull request may close this issue.

Fix QuarkusMainLauncher not returning exit code snazy/quarkus
3 participants
@snazy @gsmet @geoand