Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Otel metrics part2 - Metrics documentation #41786

Merged
merged 1 commit into from
Jul 12, 2024

Conversation

brunobat
Copy link
Contributor

@brunobat brunobat commented Jul 9, 2024

Closes #39033
It's a continuation of #39032 focused on usability and documentation.

It is now possible to configure the connections for traces and metrics with the same properties, along with the previous signal specific ones.

@quarkus-bot
Copy link

quarkus-bot bot commented Jul 9, 2024

Thanks for your pull request!

Your pull request does not follow our editorial rules. Could you have a look?

  • description should not be empty, describe your intent or provide links to the issues this PR is fixing (using Fixes #NNNNN) or changelogs

This message is automatically generated by a bot.

@quarkus-bot
Copy link

quarkus-bot bot commented Jul 9, 2024

/cc @radcortez (opentelemetry)

@quarkus-bot

This comment has been minimized.

@quarkus-bot

This comment has been minimized.

@quarkus-bot quarkus-bot bot added the area/docstyle issues related for manual docstyle review label Jul 11, 2024
@quarkus-bot

This comment has been minimized.

@brunobat brunobat marked this pull request as ready for review July 11, 2024 16:08
@brunobat
Copy link
Contributor Author

@luneo7 and @melloware if you want to give your review on the new documentation it would be great.

@quarkus-bot

This comment has been minimized.

Base OTel connection config and overrides.
@quarkus-bot
Copy link

quarkus-bot bot commented Jul 11, 2024

Status for workflow Quarkus Documentation CI

This is the status report for running Quarkus Documentation CI on commit 8ef35a8.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

Warning

There are other workflow runs running, you probably need to wait for their status before merging.

@melloware
Copy link
Contributor

LGTM Bruno. Excited about all these improvements.

@quarkus-bot
Copy link

quarkus-bot bot commented Jul 11, 2024

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 8ef35a8.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.

@geoand geoand merged commit 4f29520 into quarkusio:main Jul 12, 2024
32 checks passed
@quarkus-bot quarkus-bot bot added the kind/enhancement New feature or request label Jul 12, 2024
@quarkus-bot quarkus-bot bot added this to the 3.13 - main milestone Jul 12, 2024
Copy link

🙈 The PR is closed and the preview is expired.

@gsmet
Copy link
Member

gsmet commented Jul 31, 2024

@brunobat I added a redirect to the website to avoid breaking the /guides/opentelemetry link.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Add support for OpenTelemetry metrics.
6 participants