-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Otel metrics support #39032
Otel metrics support #39032
Conversation
/cc @radcortez (opentelemetry) |
@brunobat do we have any eta for this being merged ? |
Not yet @ayushghosh |
079d8d0
to
adfbf5e
Compare
6474e18
to
96c68d2
Compare
PR is ready to review. Will be working on the docs in a different PR because this one is already too big. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
The test failures are suspicious |
very... Looking into it. |
This comment has been minimized.
This comment has been minimized.
ok... fixed native mode and broke the exporter... Looking into that. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
@geoand and @radcortez can you guys review this one now? @gsmet PRs did the trick. |
This comment has been minimized.
This comment has been minimized.
The test failures seem due to a missing docker image, maybe a rerun would succeed? Is there a realistic chance to get this merged in time for the 3.13 release? |
This comment has been minimized.
This comment has been minimized.
@brunobat is this ready from your perspective? Asking so I can start looking at it or not |
The metrics part yes, @geoand. This PR is already too big.
|
Gotcha, thanks a lot |
This makes perfect sense, but I just want to make sure you are aware and okay with the fact this is will make backporting fixes to 3.8 harder. |
.../runtime/src/main/java/io/quarkus/opentelemetry/runtime/config/build/MetricsBuildConfig.java
Show resolved
Hide resolved
...ntime/src/main/java/io/quarkus/opentelemetry/runtime/exporter/otlp/OTelExporterRecorder.java
Outdated
Show resolved
Hide resolved
import io.vertx.core.http.HttpMethod; | ||
import io.vertx.core.tracing.TracingPolicy; | ||
|
||
final class VertxHttpExporter implements SpanExporter { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I assume this is not needed because of the new VertxHttpSender? If so, maybe the old class can be renamed to the new one so we can retain the git history?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
makes sense
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry... Just tried it but I'm not sure how to do this without creating a mess.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, no problem
Yes, that will be a pain, but my OCD makes me move them to a new package. Day to day operations will get increasingly confusing, especially when logging is brought in as well. |
Sure, just wanted to make sure you were aware. I'm +1 for this, I just had some comments |
…ted tests to work with it. OTel Metrics off by default
Status for workflow
|
Things to look at:
quarkus.otel.metrics.enabled=false
by default at build time.Includes:
Ongoing: