Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document how to access all partitions #35565

Closed
wants to merge 1 commit into from
Closed

Document how to access all partitions #35565

wants to merge 1 commit into from

Conversation

seepine
Copy link
Contributor

@seepine seepine commented Aug 25, 2023

Add document for #35492, if necessary.

@github-actions
Copy link

github-actions bot commented Aug 25, 2023 •
edited
Loading

🙈 The PR is closed and the preview is expired.

@yrodiere
Copy link
Member

Hi! Thanks for the PR.

I'm not sure we want this in such a prominent example, since we know from experience people copy/paste code from the documentation, and if they don't need this feature they would be copy-pasting a security vulnerability.

Also, this only works for the DISCRIMINATOR approach, right? If so maybe it would make more sense to add a note in the section about discriminator multi-tenancy. I wouldn't bother with an example though, mentioning the method to override would be enough IMO.

@seepine
Copy link
Contributor Author

seepine commented Aug 28, 2023

You are right, this may be a niche demand.

@seepine seepine closed this Aug 28, 2023
@quarkus-bot quarkus-bot bot added the triage/invalid This doesn't seem right label Aug 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
area/documentation triage/invalid This doesn't seem right
Projects
Quarkus Documentation
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@seepine @yrodiere