-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for multi tenancy root mode #35492
Conversation
Thanks for your pull request! The title of your pull request does not follow our editorial rules. Could you have a look?
This message is automatically generated by a bot. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks a lot!
Let's merge if CI passes.
This comment has been minimized.
This comment has been minimized.
Looks like some imports are not sorted automatically. I'll fix it and force-push to your branch for this PR. You might want to look into this for your next PR :) |
Sorry i overlooked this Perhaps I still need to remove imports* ? import static org.hamcrest.Matchers.*;
|
If this was in your PR, yes that was probably the problem. I didn't look, I just executed |
Please review again, i will respond promptly if there are any problems. |
✔️ The latest workflow run for the pull request has completed successfully. It should be safe to merge provided you have a look at the other checks in the summary. |
Merged, will be available in Quarkus 3.4. Thanks again! |
If you need it sooner and given I think it doesn't break anything (@yrodiere do you confirm?), I could be convinced to backport it to the next 3.3 micro. |
Yes it does seem safe. |
Fixes #35424