Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for multi tenancy root mode #35492

Merged
merged 1 commit into from
Aug 23, 2023
Merged

Conversation

seepine
Copy link
Contributor

@seepine seepine commented Aug 23, 2023

Fixes #35424

@quarkus-bot quarkus-bot bot added area/hibernate-orm Hibernate ORM area/persistence OBSOLETE, DO NOT USE labels Aug 23, 2023
@quarkus-bot
Copy link

quarkus-bot bot commented Aug 23, 2023

/cc @Sanne (hibernate-orm), @gsmet (hibernate-orm), @yrodiere (hibernate-orm)

@quarkus-bot
Copy link

quarkus-bot bot commented Aug 23, 2023

Thanks for your pull request!

The title of your pull request does not follow our editorial rules. Could you have a look?

  • title should not contain an issue number (use Fix #1234 in the description instead)

This message is automatically generated by a bot.

@seepine seepine changed the title Support for multi tenancy root mode #35424 Support for multi tenancy root mode Aug 23, 2023
Copy link
Member

@yrodiere yrodiere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks a lot!

Let's merge if CI passes.

@yrodiere yrodiere added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Aug 23, 2023
@quarkus-bot

This comment has been minimized.

@yrodiere
Copy link
Member

Looks like some imports are not sorted automatically.

I'll fix it and force-push to your branch for this PR.

You might want to look into this for your next PR :)

@seepine
Copy link
Contributor Author

seepine commented Aug 23, 2023

Looks like some imports are not sorted automatically.

I'll fix it and force-push to your branch for this PR.

You might want to look into this for your next PR :)

Sorry i overlooked this

Perhaps I still need to remove imports* ?

import static org.hamcrest.Matchers.*;
Next, disable wildcard imports: navigate to Editor -> Code Style -> Java -> Imports and set Class count to use import with '*' to 999. Do the same with Names count to use static import with '*'.

@yrodiere
Copy link
Member

Looks like some imports are not sorted automatically.
I'll fix it and force-push to your branch for this PR.
You might want to look into this for your next PR :)

Sorry i overlooked this

Perhaps I still need to remove imports* ?

import static org.hamcrest.Matchers.*;
Next, disable wildcard imports: navigate to Editor -> Code Style -> Java -> Imports and set Class count to use import with '*' to 999. Do the same with Names count to use static import with '*'.

If this was in your PR, yes that was probably the problem. I didn't look, I just executed ./mvnw process-sources and let it automatically fix all problems 😅

@seepine
Copy link
Contributor Author

seepine commented Aug 23, 2023

Looks like some imports are not sorted automatically.
I'll fix it and force-push to your branch for this PR.
You might want to look into this for your next PR :)

Sorry i overlooked this
Perhaps I still need to remove imports* ?

import static org.hamcrest.Matchers.*;
Next, disable wildcard imports: navigate to Editor -> Code Style -> Java -> Imports and set Class count to use import with '*' to 999. Do the same with Names count to use static import with '*'.

If this was in your PR, yes that was probably the problem. I didn't look, I just executed ./mvnw process-sources and let it automatically fix all problems 😅

Please review again, i will respond promptly if there are any problems.

@quarkus-bot
Copy link

quarkus-bot bot commented Aug 23, 2023

✔️ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

@yrodiere yrodiere merged commit ca83189 into quarkusio:main Aug 23, 2023
37 checks passed
@quarkus-bot quarkus-bot bot added kind/enhancement New feature or request and removed triage/waiting-for-ci Ready to merge when CI successfully finishes labels Aug 23, 2023
@quarkus-bot quarkus-bot bot added this to the 3.4 - main milestone Aug 23, 2023
@yrodiere
Copy link
Member

Merged, will be available in Quarkus 3.4. Thanks again!

@gsmet
Copy link
Member

gsmet commented Aug 23, 2023

If you need it sooner and given I think it doesn't break anything (@yrodiere do you confirm?), I could be convinced to backport it to the next 3.3 micro.
Let me know.

@yrodiere
Copy link
Member

given I think it doesn't break anything (@yrodiere do you confirm?)

Yes it does seem safe.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/hibernate-orm Hibernate ORM area/persistence OBSOLETE, DO NOT USE kind/enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

How support multiple tenant root with hibernate6 ?
3 participants