Fix ElasticSearch Dev Services container restart

[apatrida]

DevServices for ElasticSearch checks for a configuration change to decide if the container must be restarted. The error is that the configuration class does not actually implement equals() nor hashCode() and always indicates that the configuration changed when really no comparison was ever made.

Fixes #30384

This should be able to be applied to various 2.x and 3.x branches as the affected code has been stable for some time.

[quarkus-bot]

/cc @gsmet (elasticsearch), @loicmathieu (elasticsearch), @yrodiere (elasticsearch)

[yrodiere]

Thanks.

Interestingly, other dev services use a separate class to hold config data:

quarkus/extensions/kafka-client/deployment/src/main/java/io/quarkus/kafka/client/deployment/DevServicesKafkaProcessor.java

Line 80 in 0d1a93f

KafkaDevServiceCfg configuration = getConfiguration(kafkaClientBuildTimeConfig);

But I suppose if it works without that data holder, we may as well avoid it.

[yrodiere]

@apatrida Looks like there are some formatting errors, see the message from CI. Could you please have a look?

[gsmet]

I fixed the formatting issue and force pushed.

[quarkus-bot]

✔️ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

[yrodiere]

Merged, thanks!

[apatrida]

thanks @gsmet for the assist.

@yrodiere I did notice that, but wanted to minimize the impact on the code for the fix. I checked the Kafka extension and a few others and noted the separation.

With limited time, I went for the direct version with lowest risk.