-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Trailing comma is lost from prometheus metrics #30343
Comments
/cc @ebullient (metrics), @jmartisk (metrics) |
@jtama -- this is a side-effect of support for exemplars (#28360). The the default format for Prometheus changed to OpenMetrics, which does have some differences, most notably the trailng comments. We'll need to add comments to the release notes for 2.16, and make sure they are noted for 2.15 and previous. We should also ensure that if an accept header for prometheus comes in, we honor that (we aren't currently checking for the accept header). |
I agree it should be documented, just where should I add those pieces of information ? |
Let's work with @gsmet to get text where it needs to be for 2.16 release notes and potential 2.15 backport. |
Just add the text here and I will integrate it in the 2.15 migration guide. |
See quarkusio/quarkus#30343 for details
See quarkusio/quarkus#30343 for details
I confirm whatever the accept header comes in, the For @gsmet : Starting from now on (replace with exact 2.15 and 2.16 versions 😀) the format for Does it suits you ? |
Starting from Quarkus 2.16, the trailing comma was dropped from Prometheus metrics This change either allows tests to use both options, or disables them on older Quarkus versions. See quarkusio/quarkus#30343 for details
Starting from Quarkus 2.16, the trailing comma was dropped from Prometheus metrics This change either allows tests to use both options, or disables them on older Quarkus versions. See quarkusio/quarkus#30343 for details
yes |
Sorry for the delay. @ebullient We have to choose the default MIME_TYPE for the We have an issue though io.smallrye.metrics.MetricsRequestHandler#isKnownMediaType only accepts :
So we have to either do a PR on small-rye or say that if we receive |
Not sure why that matters. Smallrye Metrics makes its own assertions about format, and the Micrometer extension makes no pretensions about being "compliant"... it's a best-effort/don't-break-the-universe kind of arrangement. We just need to look at the accept headers and do the right thing here: Line 36 in 1672206
Specifically so that we call the right scrape variant here: Line 52 in 1672206
|
Yes, I already have something working for this part. But the Line 84 in 4cef3b7
And it prevents the user to any other MIME Type than the ones described in the above comment. |
that only applies when the smallrye metrics extension is enabled... Micrometer registers its own, here: Line 88 in 1672206
(micrometer & smallrye-metrics extensions are mutually exclusive) |
Ok so that's what trigger's a 406: Line 28 in 1672206
So I have something running, I can put up a PR. |
IIRC, the challenge was also having the json exporter (compat with MP) enabled.. and something w/ precedence for the route.. The test of interest... |
Ok, the only question is : what should we default to: |
I've lost the thread: Update you suggested for docs (with accidental edits):
|
This MR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [flow-bin](https://github.com/flowtype/flow-bin) ([changelog](https://github.com/facebook/flow/blob/master/Changelog.md)) | devDependencies | minor | [`^0.198.0` -> `^0.199.0`](https://renovatebot.com/diffs/npm/flow-bin/0.198.0/0.199.0) | | [org.postgresql:postgresql](https://jdbc.postgresql.org) ([source](https://github.com/pgjdbc/pgjdbc)) | build | patch | `42.5.1` -> `42.5.2` | | [io.quarkus:quarkus-maven-plugin](https://github.com/quarkusio/quarkus) | build | patch | `2.16.0.Final` -> `2.16.1.Final` | | [io.quarkus:quarkus-universe-bom](https://github.com/quarkusio/quarkus-platform) | import | patch | `2.16.0.Final` -> `2.16.1.Final` | | [org.apache.maven.plugins:maven-enforcer-plugin](https://maven.apache.org/enforcer/) | build | minor | `3.1.0` -> `3.2.1` | --- ### Release Notes <details> <summary>flowtype/flow-bin</summary> ### [`v0.199.0`](flow/flow-bin@0568b6e...05bb4e3) [Compare Source](flow/flow-bin@0568b6e...05bb4e3) ### [`v0.198.2`](flow/flow-bin@0d01841...0568b6e) [Compare Source](flow/flow-bin@0d01841...0568b6e) ### [`v0.198.1`](flow/flow-bin@2b180bb...0d01841) [Compare Source](flow/flow-bin@2b180bb...0d01841) </details> <details> <summary>pgjdbc/pgjdbc</summary> ### [`v42.5.2`](https://github.com/pgjdbc/pgjdbc/blob/HEAD/CHANGELOG.md#​4252-2023-01-31-143046--0500) ##### Changed docs: specify that timeouts are in seconds and there is a maximum. Housekeeping on some tests fixes [#Issue 2671](pgjdbc/pgjdbc#2671) [MR #​2686](pgjdbc/pgjdbc#2686) docs: clarify binaryTransfer and add it to README [MR# 2698](pgjdbc/pgjdbc#2698) docs: Document the need to encode reserved characters in the connection URL [MR #​2700](pgjdbc/pgjdbc#2700) feat: Define binary transfer for custom types dynamically/automatically fixes [Issue #​2554](pgjdbc/pgjdbc#2554) [MR #​2556](pgjdbc/pgjdbc#2556) ##### Added fix: added gssResponseTimeout as part of [MR #​2687](pgjdbc/pgjdbc#2687) to make sure we don't wait forever on a GSS RESPONSE ##### Fixed fix: Ensure case of XML tags in Maven snippet is correct [MR #​2682](pgjdbc/pgjdbc#2682) fix: Make sure socket is closed if an exception is thrown in createSocket fixes [Issue #​2684](pgjdbc/pgjdbc#2684) [MR #​2685](pgjdbc/pgjdbc#2685) fix: Apply patch from [Issue #​2683](pgjdbc/pgjdbc#2683) to fix hanging ssl connections [MR #​2687](pgjdbc/pgjdbc#2687) fix - binary conversion of (very) long numeric values (longer than 4 \* 2^15 digits) [MR #​2697](pgjdbc/pgjdbc#2697) fixes [Issue #​2695](pgjdbc/pgjdbc#2695) minor: enhance readability connection of startup params [MR #​2705](pgjdbc/pgjdbc#2785) </details> <details> <summary>quarkusio/quarkus</summary> ### [`v2.16.1.Final`](https://github.com/quarkusio/quarkus/releases/tag/2.16.1.Final) [Compare Source](quarkusio/quarkus@2.16.0.Final...2.16.1.Final) ##### Complete changelog - [#​30729](quarkusio/quarkus#30729) - Bump mariadb-java-client from 3.1.1 to 3.1.2 - [#​30724](quarkusio/quarkus#30724) - Upgrade to Mutiny 1.9.0 - [#​30722](quarkusio/quarkus#30722) - Set SameSite Strict only on OIDC session cookie - [#​30720](quarkusio/quarkus#30720) - Bump picocli.version from 4.7.0 to 4.7.1 - [#​30719](quarkusio/quarkus#30719) - Bump jackson-bom from 2.14.1 to 2.14.2 - [#​30715](quarkusio/quarkus#30715) - PanacheRepositoryResource should implement ReactiveRestDataResource - [#​30713](quarkusio/quarkus#30713) - Use MapProperty instead of Map - [#​30694](quarkusio/quarkus#30694) - Use newer API for creating tmp files in RESTEasy Reactive - [#​30692](quarkusio/quarkus#30692) - Bump htmlunit version to 2.70.0 - [#​30686](quarkusio/quarkus#30686) - Don't fail send when a sse sink has been closed - [#​30681](quarkusio/quarkus#30681) - RESTEasy Reactive: SSE broadcaster fails if a sink has been closed - [#​30680](quarkusio/quarkus#30680) - Mark methods generatred by ASM transformations as synthetic - [#​30659](quarkusio/quarkus#30659) - Drop unused class GradleLogger - [#​30653](quarkusio/quarkus#30653) - Fix opening in IDE when more than IDE is running - [#​30652](quarkusio/quarkus#30652) - Match prometheus export metrics format - [#​30651](quarkusio/quarkus#30651) - ArC - use reflection fallback for PreDestroy callbacks if needed - [#​30649](quarkusio/quarkus#30649) - Document redirect options in RESTEasy Reactive - [#​30644](quarkusio/quarkus#30644) - Adjust source language absent in documentation code blocks - [#​30636](quarkusio/quarkus#30636) - PreDestroy hooks fail depending on method modifiers - [#​30635](quarkusio/quarkus#30635) - Introduce a `minimum-java-version` in the extension descriptor metadata - [#​30625](quarkusio/quarkus#30625) - OIDC authentication loop if Cookie Policy sameSite=strict - [#​30624](quarkusio/quarkus#30624) - Fix NPE obtaining a project map from Maven session - [#​30622](quarkusio/quarkus#30622) - Update invalid package in guide - [#​30612](quarkusio/quarkus#30612) - Fix import file name in redis-reference.adoc - [#​30609](quarkusio/quarkus#30609) - Qute generated resolvers - getters should take precedence over fields - [#​30593](quarkusio/quarkus#30593) - Qute validation - improve hierarchy indexing to fix assignability issues - [#​30591](quarkusio/quarkus#30591) - Resolve correct version when application version is unset - [#​30589](quarkusio/quarkus#30589) - Bump junit-bom from 5.9.1 to 5.9.2 - [#​30585](quarkusio/quarkus#30585) - Bump Microsoft SQL Server JDBC driver to 11.2.3 - [#​30584](quarkusio/quarkus#30584) - Update MS SQL JDBC driver to version 11.2.3 - [#​30576](quarkusio/quarkus#30576) - Use accept header to choose metrics export format - [#​30574](quarkusio/quarkus#30574) - Handle empty source directory for included builds - [#​30569](quarkusio/quarkus#30569) - Add default implementation for REST Data interfaces - [#​30564](quarkusio/quarkus#30564) - Update security-openid-connect-client.adoc - [#​30559](quarkusio/quarkus#30559) - container-image extension running with kubernetes extension - [#​30557](quarkusio/quarkus#30557) - AWT: JniRuntimeAccess: freetypeScaler.c calls sun.font.FontUtilities - [#​30548](quarkusio/quarkus#30548) - Add a blurb about not supporting validation.xml in Quarkus - [#​30526](quarkusio/quarkus#30526) - RESTEasy classic servlets - add RoutingContext to active request context - [#​30515](quarkusio/quarkus#30515) - Native build fails with hibernate-orm-rest-data-panache + elytron-security-properties-file - [#​30513](quarkusio/quarkus#30513) - Limit application.properties lookup to main source set - [#​30510](quarkusio/quarkus#30510) - Simplify logic in create-app.adoc and allow to define stream - [#​30501](quarkusio/quarkus#30501) - Fix HibernateOrmCodestart - [#​30500](quarkusio/quarkus#30500) - Place extension with an unknown category in the uncategorized category - [#​30496](quarkusio/quarkus#30496) - Update documentation - [#​30490](quarkusio/quarkus#30490) - Avoid adding the exception itself as a suppressed exception - [#​30488](quarkusio/quarkus#30488) - Updates to Infinispan 14.0.6.Final - [#​30485](quarkusio/quarkus#30485) - Verify code flow access token first if no UserInfo precondition exists - [#​30479](quarkusio/quarkus#30479) - Define defaultValueDocumentation for builderImage - [#​30474](quarkusio/quarkus#30474) - Docs - default value of `quarkus.native.builder-image` is not shown - [#​30470](quarkusio/quarkus#30470) - Revert --enable-monitoring with no arguments support - [#​30460](quarkusio/quarkus#30460) - Bump kafka3.version from 3.3.1 to 3.3.2 - [#​30453](quarkusio/quarkus#30453) - Gradle build failing w/ Quarkus 2.16.0 - [#​30430](quarkusio/quarkus#30430) - Bump gizmo from 1.5.0.Final to 1.6.0.Final - [#​30429](quarkusio/quarkus#30429) - Bump Keycloak version to 20.0.3 - [#​30426](quarkusio/quarkus#30426) - Fix redundant push when using buildx - [#​30424](quarkusio/quarkus#30424) - Building of container images with buildx causes build failures - [#​30423](quarkusio/quarkus#30423) - 2.15+ - Services dependent on libraries without classes no longer build - [#​30418](quarkusio/quarkus#30418) - Disable -D argument propagation in DevMojo - [#​30415](quarkusio/quarkus#30415) - Arc - Change Types#getTypeClosure so that superclasses and interfaces of producer types no longer throw on finding wildcards - [#​30412](quarkusio/quarkus#30412) - Arc - wildcard detection for producer methods/fields is too aggressive - [#​30410](quarkusio/quarkus#30410) - Introduce support for GraalVM `--enable-monitoring` - [#​30408](quarkusio/quarkus#30408) - Warning: Option 'AllowVMInspection' is deprecated and might be removed from future versions: Please use --enable-monitoring - [#​30405](quarkusio/quarkus#30405) - Quarkus Undertow doesn't work with blocking SecurityIdentityAugmentor - [#​30399](quarkusio/quarkus#30399) - Fix ElasticSearch Dev Services container restart - [#​30384](quarkusio/quarkus#30384) - Elasticsearch Dev Services restarts container on every auto-compile - [#​30368](quarkusio/quarkus#30368) - Allow Environment variables to populate property Maps in build time Config - [#​30354](quarkusio/quarkus#30354) - AWT `io.quarkus.awt.it.ImageGeometryFontsIT` native integration test failing with "GraalVM for Java 20" dev builds - [#​30347](quarkusio/quarkus#30347) - Bump junit-jupiter from 5.9.1 to 5.9.2 - [#​30343](quarkusio/quarkus#30343) - Trailing comma is lost from prometheus metrics - [#​30335](quarkusio/quarkus#30335) - Add native compilation section to Hibernate Validator guide - [#​30332](quarkusio/quarkus#30332) - NPE in toString method for Processor Parameters in kafka-streams 3.3.1 version - [#​30275](quarkusio/quarkus#30275) - Inline Log category property doesn't work - [#​30208](quarkusio/quarkus#30208) - OIDC: 401 when access-token needs to be refreshed and user-info-required=true - [#​30179](quarkusio/quarkus#30179) - Add an owasp-check profile - [#​28781](quarkusio/quarkus#28781) - RESTEasy Reactive: document redirects - [#​24027](quarkusio/quarkus#24027) - Hibernate Validator does not use META-INF/validation.xml, it should work or be stated in the documentation. - [#​23002](quarkusio/quarkus#23002) - if more than two running IDE while launching 'x' gives error </details> <details> <summary>quarkusio/quarkus-platform</summary> ### [`v2.16.1.Final`](quarkusio/quarkus-platform@2.16.0.Final...2.16.1.Final) [Compare Source](quarkusio/quarkus-platform@2.16.0.Final...2.16.1.Final) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever MR is behind base branch, or you tick the rebase/retry checkbox. 👻 **Immortal**: This MR will be recreated if closed unmerged. Get [config help](https://github.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box --- This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC4yNC4wIiwidXBkYXRlZEluVmVyIjoiMzQuMjQuMCJ9-->
author Jose Carranza <[email protected]> 1686853189 +0200 committer Jose Carranza <[email protected]> 1688565488 +0200 adding some veretx http coverage related to HttpServer, HttpServerRequest, HttpServerResponse,HttpHeaders improve form logic implement ServerWebSocket logic, remove RestEasy annotation not needed here, and use @QuarkusScenario implement ServerWebSocket logic, remove RestEasy annotation not needed here, and use @QuarkusScenario keep 999999-SNAPSHOT version keep 999999-SNAPSHOT version keep pom as in upstream/main keep pom as in upstream/main use of @ApplicationScoped and onStart to deploy HttpVertxReactiveServer, websocket test reformat code style and add HttpClient test fix websocket test redoing tests as quarkus way - just keep vertx HttpClient test Enable OpenShiftQuickstartIT with snapshot Adjust GraphQLTelemetryIT to reflect latest updates Change Quarkus CLI utils to use default streams Remove todo with outdated Zulip conversation Bump maven-checkstyle-plugin from 3.2.1 to 3.3.0 Bumps [maven-checkstyle-plugin](https://github.com/apache/maven-checkstyle-plugin) from 3.2.1 to 3.3.0. - [Commits](apache/maven-checkstyle-plugin@maven-checkstyle-plugin-3.2.1...maven-checkstyle-plugin-3.3.0) --- updated-dependencies: - dependency-name: org.apache.maven.plugins:maven-checkstyle-plugin dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Remove magical constant in PostgresPoolTest Trailing comma is no longer present in Micrometer Prometheus See quarkusio/quarkus#30343 for details Remove PostgreSQL image workaround Issue quarkus-qe/quarkus-test-framework#641 was solved Bump quarkiverse.pact.version from 1.0.0.Final to 1.0.1.Final Bumps `quarkiverse.pact.version` from 1.0.0.Final to 1.0.1.Final. Updates `quarkus-pact-provider` from 1.0.0.Final to 1.0.1.Final Updates `quarkus-pact-consumer` from 1.0.0.Final to 1.0.1.Final --- updated-dependencies: - dependency-name: io.quarkiverse.pact:quarkus-pact-provider dependency-type: direct:development update-type: version-update:semver-patch - dependency-name: io.quarkiverse.pact:quarkus-pact-consumer dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Update deprecated usage of RestSseElementType * Updating test app to use RestStreamElementType rather than the deprecated RestSseElementType. This also fixes failure of the Kafka tests running with the test app. Bump quarkus.qe.framework.version from 1.3.0.Beta16 to 1.3.0.Beta17 Bumps `quarkus.qe.framework.version` from 1.3.0.Beta16 to 1.3.0.Beta17. Updates `quarkus-test-parent` from 1.3.0.Beta16 to 1.3.0.Beta17 - [Release notes](https://github.com/quarkus-qe/quarkus-test-framework/releases) - [Changelog](https://github.com/quarkus-qe/quarkus-test-framework/blob/main/RELEASE.md) - [Commits](quarkus-qe/quarkus-test-framework@1.3.0.Beta16...1.3.0.Beta17) Updates `quarkus-test-containers` from 1.3.0.Beta16 to 1.3.0.Beta17 - [Release notes](https://github.com/quarkus-qe/quarkus-test-framework/releases) - [Changelog](https://github.com/quarkus-qe/quarkus-test-framework/blob/main/RELEASE.md) - [Commits](quarkus-qe/quarkus-test-framework@1.3.0.Beta16...1.3.0.Beta17) Updates `quarkus-test-openshift` from 1.3.0.Beta16 to 1.3.0.Beta17 - [Release notes](https://github.com/quarkus-qe/quarkus-test-framework/releases) - [Changelog](https://github.com/quarkus-qe/quarkus-test-framework/blob/main/RELEASE.md) - [Commits](quarkus-qe/quarkus-test-framework@1.3.0.Beta16...1.3.0.Beta17) --- updated-dependencies: - dependency-name: io.quarkus.qe:quarkus-test-parent dependency-type: direct:production update-type: version-update:semver-patch - dependency-name: io.quarkus.qe:quarkus-test-containers dependency-type: direct:development update-type: version-update:semver-patch - dependency-name: io.quarkus.qe:quarkus-test-openshift dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Bump tj-actions/changed-files from 35.9.2 to 36.0.8 Bumps [tj-actions/changed-files](https://github.com/tj-actions/changed-files) from 35.9.2 to 36.0.8. - [Release notes](https://github.com/tj-actions/changed-files/releases) - [Changelog](https://github.com/tj-actions/changed-files/blob/main/HISTORY.md) - [Commits](tj-actions/changed-files@v35.9.2...v36.0.8) --- updated-dependencies: - dependency-name: tj-actions/changed-files dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]> Add option to debug Quarkus Test Suite Rename PostgreSQL image instances Extends quarkus-qe#1240 Bump checkstyle from 10.11.0 to 10.12.0 Bumps [checkstyle](https://github.com/checkstyle/checkstyle) from 10.11.0 to 10.12.0. - [Release notes](https://github.com/checkstyle/checkstyle/releases) - [Commits](checkstyle/checkstyle@checkstyle-10.11.0...checkstyle-10.12.0) --- updated-dependencies: - dependency-name: com.puppycrawl.tools:checkstyle dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Change PostgresqlService instances to use default properties Related issue quarkus-qe/quarkus-test-framework#455 was fixed Bump tj-actions/changed-files from 36.0.8 to 36.0.10 Bumps [tj-actions/changed-files](https://github.com/tj-actions/changed-files) from 36.0.8 to 36.0.10. - [Release notes](https://github.com/tj-actions/changed-files/releases) - [Changelog](https://github.com/tj-actions/changed-files/blob/main/HISTORY.md) - [Commits](tj-actions/changed-files@v36.0.8...v36.0.10) --- updated-dependencies: - dependency-name: tj-actions/changed-files dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Use only major version tj-actions/changed-files Fix failing HTTP DEV mode log checks Disable DomainSocketIT due to upstream bug Bump formatter-maven-plugin from 2.21.0 to 2.23.0 Bumps [formatter-maven-plugin](https://github.com/revelc/formatter-maven-plugin) from 2.21.0 to 2.23.0. - [Changelog](https://github.com/revelc/formatter-maven-plugin/blob/main/CHANGELOG.md) - [Commits](revelc/formatter-maven-plugin@formatter-maven-plugin-2.21.0...formatter-maven-plugin-2.23.0) --- updated-dependencies: - dependency-name: net.revelc.code.formatter:formatter-maven-plugin dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Verify OIDC service app dont generate enc. key Revert "Fix failing HTTP DEV mode log checks" This reverts commit 82bba48. Verify REST Client Reactive support truststore Replace OpenTracing with OTel in javaee-like-getting-started The goal is to have a module which combines OTel with other extensions, namely `smallrye-jwt` and `smallrye-openapi`.
author Jose Carranza <[email protected]> 1686853189 +0200 committer Jose Carranza <[email protected]> 1688565488 +0200 adding some veretx http coverage related to HttpServer, HttpServerRequest, HttpServerResponse,HttpHeaders improve form logic implement ServerWebSocket logic, remove RestEasy annotation not needed here, and use @QuarkusScenario implement ServerWebSocket logic, remove RestEasy annotation not needed here, and use @QuarkusScenario keep 999999-SNAPSHOT version keep 999999-SNAPSHOT version keep pom as in upstream/main keep pom as in upstream/main use of @ApplicationScoped and onStart to deploy HttpVertxReactiveServer, websocket test reformat code style and add HttpClient test fix websocket test redoing tests as quarkus way - just keep vertx HttpClient test Enable OpenShiftQuickstartIT with snapshot Adjust GraphQLTelemetryIT to reflect latest updates Change Quarkus CLI utils to use default streams Remove todo with outdated Zulip conversation Bump maven-checkstyle-plugin from 3.2.1 to 3.3.0 Bumps [maven-checkstyle-plugin](https://github.com/apache/maven-checkstyle-plugin) from 3.2.1 to 3.3.0. - [Commits](apache/maven-checkstyle-plugin@maven-checkstyle-plugin-3.2.1...maven-checkstyle-plugin-3.3.0) --- updated-dependencies: - dependency-name: org.apache.maven.plugins:maven-checkstyle-plugin dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Remove magical constant in PostgresPoolTest Trailing comma is no longer present in Micrometer Prometheus See quarkusio/quarkus#30343 for details Remove PostgreSQL image workaround Issue quarkus-qe/quarkus-test-framework#641 was solved Bump quarkiverse.pact.version from 1.0.0.Final to 1.0.1.Final Bumps `quarkiverse.pact.version` from 1.0.0.Final to 1.0.1.Final. Updates `quarkus-pact-provider` from 1.0.0.Final to 1.0.1.Final Updates `quarkus-pact-consumer` from 1.0.0.Final to 1.0.1.Final --- updated-dependencies: - dependency-name: io.quarkiverse.pact:quarkus-pact-provider dependency-type: direct:development update-type: version-update:semver-patch - dependency-name: io.quarkiverse.pact:quarkus-pact-consumer dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Update deprecated usage of RestSseElementType * Updating test app to use RestStreamElementType rather than the deprecated RestSseElementType. This also fixes failure of the Kafka tests running with the test app. Bump quarkus.qe.framework.version from 1.3.0.Beta16 to 1.3.0.Beta17 Bumps `quarkus.qe.framework.version` from 1.3.0.Beta16 to 1.3.0.Beta17. Updates `quarkus-test-parent` from 1.3.0.Beta16 to 1.3.0.Beta17 - [Release notes](https://github.com/quarkus-qe/quarkus-test-framework/releases) - [Changelog](https://github.com/quarkus-qe/quarkus-test-framework/blob/main/RELEASE.md) - [Commits](quarkus-qe/quarkus-test-framework@1.3.0.Beta16...1.3.0.Beta17) Updates `quarkus-test-containers` from 1.3.0.Beta16 to 1.3.0.Beta17 - [Release notes](https://github.com/quarkus-qe/quarkus-test-framework/releases) - [Changelog](https://github.com/quarkus-qe/quarkus-test-framework/blob/main/RELEASE.md) - [Commits](quarkus-qe/quarkus-test-framework@1.3.0.Beta16...1.3.0.Beta17) Updates `quarkus-test-openshift` from 1.3.0.Beta16 to 1.3.0.Beta17 - [Release notes](https://github.com/quarkus-qe/quarkus-test-framework/releases) - [Changelog](https://github.com/quarkus-qe/quarkus-test-framework/blob/main/RELEASE.md) - [Commits](quarkus-qe/quarkus-test-framework@1.3.0.Beta16...1.3.0.Beta17) --- updated-dependencies: - dependency-name: io.quarkus.qe:quarkus-test-parent dependency-type: direct:production update-type: version-update:semver-patch - dependency-name: io.quarkus.qe:quarkus-test-containers dependency-type: direct:development update-type: version-update:semver-patch - dependency-name: io.quarkus.qe:quarkus-test-openshift dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Bump tj-actions/changed-files from 35.9.2 to 36.0.8 Bumps [tj-actions/changed-files](https://github.com/tj-actions/changed-files) from 35.9.2 to 36.0.8. - [Release notes](https://github.com/tj-actions/changed-files/releases) - [Changelog](https://github.com/tj-actions/changed-files/blob/main/HISTORY.md) - [Commits](tj-actions/changed-files@v35.9.2...v36.0.8) --- updated-dependencies: - dependency-name: tj-actions/changed-files dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]> Add option to debug Quarkus Test Suite Rename PostgreSQL image instances Extends quarkus-qe#1240 Bump checkstyle from 10.11.0 to 10.12.0 Bumps [checkstyle](https://github.com/checkstyle/checkstyle) from 10.11.0 to 10.12.0. - [Release notes](https://github.com/checkstyle/checkstyle/releases) - [Commits](checkstyle/checkstyle@checkstyle-10.11.0...checkstyle-10.12.0) --- updated-dependencies: - dependency-name: com.puppycrawl.tools:checkstyle dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Change PostgresqlService instances to use default properties Related issue quarkus-qe/quarkus-test-framework#455 was fixed Bump tj-actions/changed-files from 36.0.8 to 36.0.10 Bumps [tj-actions/changed-files](https://github.com/tj-actions/changed-files) from 36.0.8 to 36.0.10. - [Release notes](https://github.com/tj-actions/changed-files/releases) - [Changelog](https://github.com/tj-actions/changed-files/blob/main/HISTORY.md) - [Commits](tj-actions/changed-files@v36.0.8...v36.0.10) --- updated-dependencies: - dependency-name: tj-actions/changed-files dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Use only major version tj-actions/changed-files Fix failing HTTP DEV mode log checks Disable DomainSocketIT due to upstream bug Bump formatter-maven-plugin from 2.21.0 to 2.23.0 Bumps [formatter-maven-plugin](https://github.com/revelc/formatter-maven-plugin) from 2.21.0 to 2.23.0. - [Changelog](https://github.com/revelc/formatter-maven-plugin/blob/main/CHANGELOG.md) - [Commits](revelc/formatter-maven-plugin@formatter-maven-plugin-2.21.0...formatter-maven-plugin-2.23.0) --- updated-dependencies: - dependency-name: net.revelc.code.formatter:formatter-maven-plugin dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Verify OIDC service app dont generate enc. key Revert "Fix failing HTTP DEV mode log checks" This reverts commit 82bba48. Verify REST Client Reactive support truststore Replace OpenTracing with OTel in javaee-like-getting-started The goal is to have a module which combines OTel with other extensions, namely `smallrye-jwt` and `smallrye-openapi`.
author Jose Carranza <[email protected]> 1686853189 +0200 committer Jose Carranza <[email protected]> 1688565488 +0200 adding some veretx http coverage related to HttpServer, HttpServerRequest, HttpServerResponse,HttpHeaders improve form logic implement ServerWebSocket logic, remove RestEasy annotation not needed here, and use @QuarkusScenario implement ServerWebSocket logic, remove RestEasy annotation not needed here, and use @QuarkusScenario keep 999999-SNAPSHOT version keep 999999-SNAPSHOT version keep pom as in upstream/main keep pom as in upstream/main use of @ApplicationScoped and onStart to deploy HttpVertxReactiveServer, websocket test reformat code style and add HttpClient test fix websocket test redoing tests as quarkus way - just keep vertx HttpClient test Enable OpenShiftQuickstartIT with snapshot Adjust GraphQLTelemetryIT to reflect latest updates Change Quarkus CLI utils to use default streams Remove todo with outdated Zulip conversation Bump maven-checkstyle-plugin from 3.2.1 to 3.3.0 Bumps [maven-checkstyle-plugin](https://github.com/apache/maven-checkstyle-plugin) from 3.2.1 to 3.3.0. - [Commits](apache/maven-checkstyle-plugin@maven-checkstyle-plugin-3.2.1...maven-checkstyle-plugin-3.3.0) --- updated-dependencies: - dependency-name: org.apache.maven.plugins:maven-checkstyle-plugin dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Remove magical constant in PostgresPoolTest Trailing comma is no longer present in Micrometer Prometheus See quarkusio/quarkus#30343 for details Remove PostgreSQL image workaround Issue quarkus-qe/quarkus-test-framework#641 was solved Bump quarkiverse.pact.version from 1.0.0.Final to 1.0.1.Final Bumps `quarkiverse.pact.version` from 1.0.0.Final to 1.0.1.Final. Updates `quarkus-pact-provider` from 1.0.0.Final to 1.0.1.Final Updates `quarkus-pact-consumer` from 1.0.0.Final to 1.0.1.Final --- updated-dependencies: - dependency-name: io.quarkiverse.pact:quarkus-pact-provider dependency-type: direct:development update-type: version-update:semver-patch - dependency-name: io.quarkiverse.pact:quarkus-pact-consumer dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Update deprecated usage of RestSseElementType * Updating test app to use RestStreamElementType rather than the deprecated RestSseElementType. This also fixes failure of the Kafka tests running with the test app. Bump quarkus.qe.framework.version from 1.3.0.Beta16 to 1.3.0.Beta17 Bumps `quarkus.qe.framework.version` from 1.3.0.Beta16 to 1.3.0.Beta17. Updates `quarkus-test-parent` from 1.3.0.Beta16 to 1.3.0.Beta17 - [Release notes](https://github.com/quarkus-qe/quarkus-test-framework/releases) - [Changelog](https://github.com/quarkus-qe/quarkus-test-framework/blob/main/RELEASE.md) - [Commits](quarkus-qe/quarkus-test-framework@1.3.0.Beta16...1.3.0.Beta17) Updates `quarkus-test-containers` from 1.3.0.Beta16 to 1.3.0.Beta17 - [Release notes](https://github.com/quarkus-qe/quarkus-test-framework/releases) - [Changelog](https://github.com/quarkus-qe/quarkus-test-framework/blob/main/RELEASE.md) - [Commits](quarkus-qe/quarkus-test-framework@1.3.0.Beta16...1.3.0.Beta17) Updates `quarkus-test-openshift` from 1.3.0.Beta16 to 1.3.0.Beta17 - [Release notes](https://github.com/quarkus-qe/quarkus-test-framework/releases) - [Changelog](https://github.com/quarkus-qe/quarkus-test-framework/blob/main/RELEASE.md) - [Commits](quarkus-qe/quarkus-test-framework@1.3.0.Beta16...1.3.0.Beta17) --- updated-dependencies: - dependency-name: io.quarkus.qe:quarkus-test-parent dependency-type: direct:production update-type: version-update:semver-patch - dependency-name: io.quarkus.qe:quarkus-test-containers dependency-type: direct:development update-type: version-update:semver-patch - dependency-name: io.quarkus.qe:quarkus-test-openshift dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Bump tj-actions/changed-files from 35.9.2 to 36.0.8 Bumps [tj-actions/changed-files](https://github.com/tj-actions/changed-files) from 35.9.2 to 36.0.8. - [Release notes](https://github.com/tj-actions/changed-files/releases) - [Changelog](https://github.com/tj-actions/changed-files/blob/main/HISTORY.md) - [Commits](tj-actions/changed-files@v35.9.2...v36.0.8) --- updated-dependencies: - dependency-name: tj-actions/changed-files dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]> Add option to debug Quarkus Test Suite Rename PostgreSQL image instances Extends quarkus-qe#1240 Bump checkstyle from 10.11.0 to 10.12.0 Bumps [checkstyle](https://github.com/checkstyle/checkstyle) from 10.11.0 to 10.12.0. - [Release notes](https://github.com/checkstyle/checkstyle/releases) - [Commits](checkstyle/checkstyle@checkstyle-10.11.0...checkstyle-10.12.0) --- updated-dependencies: - dependency-name: com.puppycrawl.tools:checkstyle dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Change PostgresqlService instances to use default properties Related issue quarkus-qe/quarkus-test-framework#455 was fixed Bump tj-actions/changed-files from 36.0.8 to 36.0.10 Bumps [tj-actions/changed-files](https://github.com/tj-actions/changed-files) from 36.0.8 to 36.0.10. - [Release notes](https://github.com/tj-actions/changed-files/releases) - [Changelog](https://github.com/tj-actions/changed-files/blob/main/HISTORY.md) - [Commits](tj-actions/changed-files@v36.0.8...v36.0.10) --- updated-dependencies: - dependency-name: tj-actions/changed-files dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Use only major version tj-actions/changed-files Fix failing HTTP DEV mode log checks Disable DomainSocketIT due to upstream bug Bump formatter-maven-plugin from 2.21.0 to 2.23.0 Bumps [formatter-maven-plugin](https://github.com/revelc/formatter-maven-plugin) from 2.21.0 to 2.23.0. - [Changelog](https://github.com/revelc/formatter-maven-plugin/blob/main/CHANGELOG.md) - [Commits](revelc/formatter-maven-plugin@formatter-maven-plugin-2.21.0...formatter-maven-plugin-2.23.0) --- updated-dependencies: - dependency-name: net.revelc.code.formatter:formatter-maven-plugin dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Verify OIDC service app dont generate enc. key Revert "Fix failing HTTP DEV mode log checks" This reverts commit 82bba48. Verify REST Client Reactive support truststore Replace OpenTracing with OTel in javaee-like-getting-started The goal is to have a module which combines OTel with other extensions, namely `smallrye-jwt` and `smallrye-openapi`. keep DomainSocketIT as in the upstream repo fix httpClient test Bump quarkus-qpid-jms from 2.2.0 to 2.3.0 Bumps [quarkus-qpid-jms](https://github.com/amqphub/quarkus-qpid-jms) from 2.2.0 to 2.3.0. - [Commits](amqphub/quarkus-qpid-jms@2.2.0...2.3.0) --- updated-dependencies: - dependency-name: org.amqphub.quarkus:quarkus-qpid-jms dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Flyway now requires dedicated dep for Oracle Migrate deprecated configuration properties for Artemis URL and kafka Remove todo with resolved issue from pom Issue was quarkus-qe#609 was closed
Bump quarkus-qpid-jms from 2.2.0 to 2.3.0 Bumps [quarkus-qpid-jms](https://github.com/amqphub/quarkus-qpid-jms) from 2.2.0 to 2.3.0. - [Commits](amqphub/quarkus-qpid-jms@2.2.0...2.3.0) --- updated-dependencies: - dependency-name: org.amqphub.quarkus:quarkus-qpid-jms dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Flyway now requires dedicated dep for Oracle Migrate deprecated configuration properties for Artemis URL and kafka Remove todo with resolved issue from pom Issue was quarkus-qe#609 was closed Fix Workshop external app test for Ghost Isolate AgroalPoolTest to one datasource parent ff57517 author Jose Carranza <[email protected]> 1686853189 +0200 committer Jose Carranza <[email protected]> 1688565488 +0200 adding some veretx http coverage related to HttpServer, HttpServerRequest, HttpServerResponse,HttpHeaders improve form logic implement ServerWebSocket logic, remove RestEasy annotation not needed here, and use @QuarkusScenario implement ServerWebSocket logic, remove RestEasy annotation not needed here, and use @QuarkusScenario keep 999999-SNAPSHOT version keep 999999-SNAPSHOT version keep pom as in upstream/main keep pom as in upstream/main use of @ApplicationScoped and onStart to deploy HttpVertxReactiveServer, websocket test reformat code style and add HttpClient test fix websocket test redoing tests as quarkus way - just keep vertx HttpClient test Enable OpenShiftQuickstartIT with snapshot Adjust GraphQLTelemetryIT to reflect latest updates Change Quarkus CLI utils to use default streams Remove todo with outdated Zulip conversation Bump maven-checkstyle-plugin from 3.2.1 to 3.3.0 Bumps [maven-checkstyle-plugin](https://github.com/apache/maven-checkstyle-plugin) from 3.2.1 to 3.3.0. - [Commits](apache/maven-checkstyle-plugin@maven-checkstyle-plugin-3.2.1...maven-checkstyle-plugin-3.3.0) --- updated-dependencies: - dependency-name: org.apache.maven.plugins:maven-checkstyle-plugin dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Remove magical constant in PostgresPoolTest Trailing comma is no longer present in Micrometer Prometheus See quarkusio/quarkus#30343 for details Remove PostgreSQL image workaround Issue quarkus-qe/quarkus-test-framework#641 was solved Bump quarkiverse.pact.version from 1.0.0.Final to 1.0.1.Final Bumps `quarkiverse.pact.version` from 1.0.0.Final to 1.0.1.Final. Updates `quarkus-pact-provider` from 1.0.0.Final to 1.0.1.Final Updates `quarkus-pact-consumer` from 1.0.0.Final to 1.0.1.Final --- updated-dependencies: - dependency-name: io.quarkiverse.pact:quarkus-pact-provider dependency-type: direct:development update-type: version-update:semver-patch - dependency-name: io.quarkiverse.pact:quarkus-pact-consumer dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Update deprecated usage of RestSseElementType * Updating test app to use RestStreamElementType rather than the deprecated RestSseElementType. This also fixes failure of the Kafka tests running with the test app. Bump quarkus.qe.framework.version from 1.3.0.Beta16 to 1.3.0.Beta17 Bumps `quarkus.qe.framework.version` from 1.3.0.Beta16 to 1.3.0.Beta17. Updates `quarkus-test-parent` from 1.3.0.Beta16 to 1.3.0.Beta17 - [Release notes](https://github.com/quarkus-qe/quarkus-test-framework/releases) - [Changelog](https://github.com/quarkus-qe/quarkus-test-framework/blob/main/RELEASE.md) - [Commits](quarkus-qe/quarkus-test-framework@1.3.0.Beta16...1.3.0.Beta17) Updates `quarkus-test-containers` from 1.3.0.Beta16 to 1.3.0.Beta17 - [Release notes](https://github.com/quarkus-qe/quarkus-test-framework/releases) - [Changelog](https://github.com/quarkus-qe/quarkus-test-framework/blob/main/RELEASE.md) - [Commits](quarkus-qe/quarkus-test-framework@1.3.0.Beta16...1.3.0.Beta17) Updates `quarkus-test-openshift` from 1.3.0.Beta16 to 1.3.0.Beta17 - [Release notes](https://github.com/quarkus-qe/quarkus-test-framework/releases) - [Changelog](https://github.com/quarkus-qe/quarkus-test-framework/blob/main/RELEASE.md) - [Commits](quarkus-qe/quarkus-test-framework@1.3.0.Beta16...1.3.0.Beta17) --- updated-dependencies: - dependency-name: io.quarkus.qe:quarkus-test-parent dependency-type: direct:production update-type: version-update:semver-patch - dependency-name: io.quarkus.qe:quarkus-test-containers dependency-type: direct:development update-type: version-update:semver-patch - dependency-name: io.quarkus.qe:quarkus-test-openshift dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Bump tj-actions/changed-files from 35.9.2 to 36.0.8 Bumps [tj-actions/changed-files](https://github.com/tj-actions/changed-files) from 35.9.2 to 36.0.8. - [Release notes](https://github.com/tj-actions/changed-files/releases) - [Changelog](https://github.com/tj-actions/changed-files/blob/main/HISTORY.md) - [Commits](tj-actions/changed-files@v35.9.2...v36.0.8) --- updated-dependencies: - dependency-name: tj-actions/changed-files dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]> Add option to debug Quarkus Test Suite Rename PostgreSQL image instances Extends quarkus-qe#1240 Bump checkstyle from 10.11.0 to 10.12.0 Bumps [checkstyle](https://github.com/checkstyle/checkstyle) from 10.11.0 to 10.12.0. - [Release notes](https://github.com/checkstyle/checkstyle/releases) - [Commits](checkstyle/checkstyle@checkstyle-10.11.0...checkstyle-10.12.0) --- updated-dependencies: - dependency-name: com.puppycrawl.tools:checkstyle dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Change PostgresqlService instances to use default properties Related issue quarkus-qe/quarkus-test-framework#455 was fixed Bump tj-actions/changed-files from 36.0.8 to 36.0.10 Bumps [tj-actions/changed-files](https://github.com/tj-actions/changed-files) from 36.0.8 to 36.0.10. - [Release notes](https://github.com/tj-actions/changed-files/releases) - [Changelog](https://github.com/tj-actions/changed-files/blob/main/HISTORY.md) - [Commits](tj-actions/changed-files@v36.0.8...v36.0.10) --- updated-dependencies: - dependency-name: tj-actions/changed-files dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Use only major version tj-actions/changed-files Fix failing HTTP DEV mode log checks Disable DomainSocketIT due to upstream bug Bump formatter-maven-plugin from 2.21.0 to 2.23.0 Bumps [formatter-maven-plugin](https://github.com/revelc/formatter-maven-plugin) from 2.21.0 to 2.23.0. - [Changelog](https://github.com/revelc/formatter-maven-plugin/blob/main/CHANGELOG.md) - [Commits](revelc/formatter-maven-plugin@formatter-maven-plugin-2.21.0...formatter-maven-plugin-2.23.0) --- updated-dependencies: - dependency-name: net.revelc.code.formatter:formatter-maven-plugin dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Verify OIDC service app dont generate enc. key Revert "Fix failing HTTP DEV mode log checks" This reverts commit 82bba48. Verify REST Client Reactive support truststore Replace OpenTracing with OTel in javaee-like-getting-started The goal is to have a module which combines OTel with other extensions, namely `smallrye-jwt` and `smallrye-openapi`. keep DomainSocketIT as in the upstream repo fix httpClient test Bump quarkus-qpid-jms from 2.2.0 to 2.3.0 Bumps [quarkus-qpid-jms](https://github.com/amqphub/quarkus-qpid-jms) from 2.2.0 to 2.3.0. - [Commits](amqphub/quarkus-qpid-jms@2.2.0...2.3.0) --- updated-dependencies: - dependency-name: org.amqphub.quarkus:quarkus-qpid-jms dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Flyway now requires dedicated dep for Oracle Migrate deprecated configuration properties for Artemis URL and kafka Remove todo with resolved issue from pom Issue was quarkus-qe#609 was closed
Describe the bug
In all released versions (including 2.15.3.Final), prometheus metrics (accessible at 'q/metrics') has format of json object with a trailing comma. In the current main branch (tested on dc85cd0) the format is changed, and the comma was lost. Is this an expected change? Prometheus format allows[1] for both options, but that change may broke parsing of logs and therefore it would be nice to have it documented
[1] https://prometheus.io/docs/prometheus/latest/querying/operators/#aggregation-operators
Expected behavior
Example:
http_server_requests_seconds_count{method="GET",outcome="SUCCESS",status="200",uri="/hello",} 1.0
Actual behavior
http_server_requests_seconds_count{method="GET",outcome="SUCCESS",status="200",uri="/hello"} 6.0
How to Reproduce?
mvn io.quarkus.platform:quarkus-maven-plugin:2.15.3.Final:create -DprojectGroupId=org.acme -DprojectArtifactId=micrometer-quickstart -Dextensions='resteasy-reactive,micrometer-registry-prometheus'
cd micrometer-quickstart
mvn quarkus:dev -Dquarkus.platform.version=999-SNAPSHOT
curl http://localhost:8080/hello/
curl http://localhost:8080/q/metrics | grep http_server_requests_seconds_count # example, many (all?) other metrics also changed
for comparision, replace step 3 with
mvn quarkus:dev -Dquarkus.platform.version=2.15.3.Final
Output of
uname -a
orver
6.0.18-300.fc37.x86_64
Output of
java -version
17.0.4, vendor: GraalVM Community
GraalVM version (if different from Java)
No response
Quarkus version or git rev
dc85cd0
Build tool (ie. output of
mvnw --version
orgradlew --version
)Apache Maven 3.8.6 (84538c9988a25aec085021c365c560670ad80f63)
Additional information
No response
The text was updated successfully, but these errors were encountered: