-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Look for mongo client in the whole deployment #15594
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
machi1990
approved these changes
Mar 10, 2021
gsmet
approved these changes
Mar 10, 2021
glefloch
force-pushed
the
fix/mongclient-lookup
branch
from
March 10, 2021 09:12
18e659a
to
c5c040a
Compare
@mkouba I have a circular dependency :
can I use |
I think that it would be more correct to extract the @BuildStep
void additionalBeans(BuildProducer<AdditionalBeanBuildItem> additional) {
additional.produce(new AdditionalBeanBuildItem(io.quarkus.mongodb.runtime.MongoClientName.class, MongoClientName.class));
additional.produce(AdditionalBeanBuildItem.builder().addBeanClasses(MongoClients.class).setUnremovable().build());
} |
glefloch
force-pushed
the
fix/mongclient-lookup
branch
from
March 10, 2021 10:18
c5c040a
to
fbadd34
Compare
This was referenced Mar 12, 2021
Merged
This was referenced Mar 12, 2021
Merged
Closed
Merged
Merged
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in #15589 this branch looks for mongo client in the whole deployment archive.