Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Look for RedisClient in all modules #15589

Merged
merged 1 commit into from
Mar 10, 2021
Merged

Conversation

glefloch
Copy link
Member

@glefloch glefloch commented Mar 9, 2021

This branch looks for redis client in all archives. I tested it in a multi module project locally. Is there any place where I could put such a test? the integration-test/redis-client is not a multi-module project.

close #15581

@glefloch glefloch requested a review from machi1990 March 9, 2021 21:35
@glefloch glefloch requested a review from mkouba March 9, 2021 21:35
@mkouba
Copy link
Contributor

mkouba commented Mar 10, 2021

There's a formatting error:

 File '/home/runner/work/quarkus/quarkus/extensions/redis-client/deployment/src/main/java/io/quarkus/redis/client/deployment/RedisClientProcessor.java' has not been previously formatted.  Please format file and commit before running validation!

@glefloch
Copy link
Member Author

I fixed the formatting error, I pushed to fast yesterday :)

@glefloch
Copy link
Member Author

@mkouba I updated the code with BeanArchiveIndexBuildItem and fixed the formatted.

@machi1990 for the mongo extension, should we do that in an other branch ?

@machi1990
Copy link
Member

@mkouba I updated the code with BeanArchiveIndexBuildItem and fixed the formatted.

@machi1990 for the mongo extension, should we do that in an other branch ?

Thanks for the fix. Could be a separate PR or a separate commit in this PR.

This was referenced Mar 12, 2021
@glefloch glefloch deleted the fix/15581 branch August 19, 2021 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Named Redis client injection not working when used in separate JAR
4 participants