-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
External link is broken in Native Build Tips documentation page #34929
Comments
I was trying to do a PR, but the link is referencing a Not sure where it is defined or even if it should be changed or a different variable should be used (or replaced with |
The docs intentionally mention a specific GraalVM (same with other tools like Maven). |
Yes, I guess that's due to the transition from the old GraalVM versioning to the new "JDK versioning". @alina-yur is there a fixed link (like jdk-17 or similar) for We don't want our docs to point to |
hi @zakkak. Indeed we should have links for jdk 17 & jdk 20; right now this content is under /latest/, but latest will change. We will work on this, thanks for the ping. |
Thanks @alina-yur! |
Thank you for the prompt reply @alina-yur, please let us know once there is a change. |
hi @zakkak, we now have https://www.graalvm.org/jdk17/docs/ & https://www.graalvm.org/jdk20/docs/ URLs (thank you @olyagpl). There will also be |
Thanks @alina-yur! @zakkak it seems like we would need to update our adoc to include this version for the GraalVM docs links instead of what we have now (which is |
Thank you @alina-yur and @olyagpl! Correct, ideally we would do this programmatically by removing the |
Describe the bug
The link at https://quarkus.io/version/main/guides/writing-native-applications-tips#managing-proxy-classes is broken.
Current link: https://www.graalvm.org/jdk-17/reference-manual/native-image/guides/configure-dynamic-proxies/
Found:
https://www.graalvm.org/22.0/reference-manual/native-image/DynamicProxy/https://www.graalvm.org/22.1/reference-manual/native-image/DynamicProxy/https://www.graalvm.org/22.3/reference-manual/native-image/dynamic-features/DynamicProxy/https://www.graalvm.org/latest/reference-manual/native-image/dynamic-features/DynamicProxy/Caveat:It is possible that the link will break in the future if GraalVM docs structure changes again.Expected behavior
External link should load.
Actual behavior
External link doesn't load
How to Reproduce?
No response
Output of
uname -a
orver
No response
Output of
java -version
No response
GraalVM version (if different from Java)
No response
Quarkus version or git rev
No response
Build tool (ie. output of
mvnw --version
orgradlew --version
)No response
Additional information
SRC: https://github.com/quarkusio/quarkus/blob/main/docs/src/main/asciidoc/writing-native-applications-tips.adoc
The text was updated successfully, but these errors were encountered: