Improve "process paths before sub resources" scenario #995
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pjgg
force-pushed
the
http-rest-client-quarkus-2741
branch
from
1475887
to
12bd7c2
Compare
fedinskiy
requested changes
Jan 16, 2023
There was a problem hiding this comment.
In general, these tests became much less readable and much more complex. Could you change names of paths and resources to make them easier to understand? URLs like "root/method/sub/sub/subsub" make sense in our domain (checking sub-resources), URLs like "/clients/myRealm/authz/resource-server/permission/resource/" do not.
...ient-reactive/src/test/java/io/quarkus/ts/http/restclient/reactive/ReactiveRestClientIT.java
Outdated
Show resolved
Hide resolved
...ient-reactive/src/test/java/io/quarkus/ts/http/restclient/reactive/ReactiveRestClientIT.java
Outdated
Show resolved
Hide resolved
...ient-reactive/src/test/java/io/quarkus/ts/http/restclient/reactive/ReactiveRestClientIT.java
Outdated
Show resolved
Hide resolved
...ient-reactive/src/test/java/io/quarkus/ts/http/restclient/reactive/ReactiveRestClientIT.java
Outdated
Show resolved
Hide resolved
pjgg
force-pushed
the
http-rest-client-quarkus-2741
branch
from
12bd7c2
to
0f64b62
Compare
pjgg
force-pushed
the
http-rest-client-quarkus-2741
branch
from
0f64b62
to
477d065
Compare
fedinskiy
requested changes
Jan 16, 2023
...ient-reactive/src/test/java/io/quarkus/ts/http/restclient/reactive/ReactiveRestClientIT.java
Outdated
Show resolved
Hide resolved
...tive/src/main/java/io/quarkus/ts/http/restclient/reactive/ResourceAndSubResourcesClient.java
Outdated
Show resolved
Hide resolved
| public String deleteClientResource(@PathParam("clientId") String rootParam, | ||
| @PathParam("id") String id, | ||
| @QueryParam("baseUri") String baseUri) throws URISyntaxException { | ||
| if (!StringUtils.isEmpty(baseUri)) { |
There was a problem hiding this comment.
Why are we creating another client?
There was a problem hiding this comment.
Just to double-check that the issue is fixed in an Injected client but also with a RestBuilderClient. (This is why we have two scenarios on ReactiveRestClientIT)
Scenarios:
- checkProcessPathBeforeSubResources
- checkProcessPathBeforeSubResourcesManualRestClientBuild
...c/main/java/io/quarkus/ts/http/restclient/reactive/resources/PlainComplexClientResource.java
Outdated
Show resolved
Hide resolved
| @Path("/{id}") | ||
| @DELETE | ||
| public String deleteById(@PathParam("rootPath") String rootPath, @PathParam("id") String id) { | ||
| return "/clients/" + rootPath + "/resource-server/" + id; |
There was a problem hiding this comment.
Returning an URl to Delete action is slightly confusing and slightly against RFC[1]. Since we do not check full path in the tests, maybe we should replace it with "sent from resource-server" or something like that??
There was a problem hiding this comment.
We still return URI. Why is it better, than, say, String?
There was a problem hiding this comment.
Well, the issue is that the Http reactive client overwrites a sub-resource path param with a parent pathParam. So, I think that makes sense to return the full path just to verify that the "id" is not overwritten by the rootpath.
…nario There is an issue in upstream (quarkusio/quarkus#29821) that only happens under some RestClient definition hierarchy. This commit reproduces the problem in Quarkus 2.12 and earlier versions
pjgg
force-pushed
the
http-rest-client-quarkus-2741
branch
from
477d065
to
0ffedd5
Compare
fedinskiy
requested changes
Jan 16, 2023
| @Path("/{id}") | ||
| @DELETE | ||
| public String deleteById(@PathParam("rootPath") String rootPath, @PathParam("id") String id) { | ||
| return "/clients/" + rootPath + "/resource-server/" + id; |
There was a problem hiding this comment.
We still return URI. Why is it better, than, say, String?
fedinskiy
approved these changes
Jan 16, 2023
3 tasks
pjgg
pushed a commit
to pjgg/quarkus-test-suite
that referenced
this pull request
Jan 30, 2023
…nario (quarkus-qe#995) There is an issue in upstream (quarkusio/quarkus#29821) that only happens under some RestClient definition hierarchy. This commit reproduces the problem in Quarkus 2.12 and earlier versions (cherry picked from commit 2350b46)
1 task
pjgg
pushed a commit
to pjgg/quarkus-test-suite
that referenced
this pull request
Jan 30, 2023
…nario (quarkus-qe#995) There is an issue in upstream (quarkusio/quarkus#29821) that only happens under some RestClient definition hierarchy. This commit reproduces the problem in Quarkus 2.12 and earlier versions (cherry picked from commit 2350b46)
pjgg
pushed a commit
that referenced
this pull request
Feb 1, 2023
… modules (#1021) * Test Extended Architecture (XA) connection Provides coverage for https://issues.redhat.com/browse/QUARKUS-2742 (cherry picked from commit ce15b26) * Improve reactive rest client "process paths before sub resources" scenario (#995) There is an issue in upstream (quarkusio/quarkus#29821) that only happens under some RestClient definition hierarchy. This commit reproduces the problem in Quarkus 2.12 and earlier versions (cherry picked from commit 2350b46) * New Scenario: RequestScope custom context was removed after `javax.enterprise` event propagation When firing an async CDI Event, the requestScope context from the emitter briefly exists for the observer and is then terminated. This commit is a reproducer of this scenario that happens on Quarkus 2.13.0.Final (cherry picked from commit ef3eed6) * gRPC and SSE coverage for OpenTelemetry (cherry picked from commit f327c60) * Add coverage to eventbus '@ConsumeEvent' annotation (cherry picked from commit 7da0d4b) * Drop duplicated definition of quarkus-opentelemetry (cherry picked from commit b0cba7f) * OutboundSseEvent is not correctly serialized (cherry picked from commit 99b5eb1) * Check, that dev-mode is omitted on projects with pom packaging Required for QUARKUS-2757 (cherry picked from commit 4fd38c7) * Refactoring of QUARKUS-2748: adding http test and improving error messages (cherry picked from commit 6563431) * Add test for security annotations in rest-data-panache (#994) Quarkus extensions based on `rest-data-panache` support propagation of security annotations into generated JAX-RS resources. These tests provide coverage of this feature for extensions: - `quarkus-hibernate-orm-rest-data-panache` - `quarkus-spring-data-rest` See also related test plan: - https://github.com/quarkus-qe/quarkus-test-plans/blob/main/QUARKUS-2788.md (cherry picked from commit 3f7a4c8) * Add transaction-API classic scenario (cherry picked from commit 509d491) * Cover Vert.X-specific metrics. (#1019) Add new module, which uses Vert.X-based HTTP server Verify, that it works, and that it creates all required metrics Required for https://issues.redhat.com/browse/QUARKUS-2829 (cherry picked from commit 818837f) * Add missing opentelemetry exporter to Narayana scenario --------- Co-authored-by: Fedor Dudinskiy <[email protected]> Co-authored-by: Rostislav Svoboda <[email protected]> Co-authored-by: Josef Smrcka <[email protected]>
pjgg
removed
the
triage/backport-2.13?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
There is an issue in upstream that only happens under some RestClient definition hierarchy.
This commit reproduces the problem in Quarkus 2.12 and earlier versions
Reproducer:
cd /quarkus-test-suite/http/rest-client-reactivemvn clean verify -Dit.test=checkProcessPathBeforeSubResources -Dquarkus.platform.version=2.10.0.FinalPlease select the relevant options.
Checklist: