-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add test for security annotations in rest-data-panache #994
Add test for security annotations in rest-data-panache #994
Conversation
ac96b8b
to
548e7d2
Compare
run tests |
@jsmrcka investigate / fix the failures pls |
548e7d2
to
6f816de
Compare
[INFO] Quarkus QE TS: SQL Database: Panache + Flyway ...... FAILURE [08:55 min]
Native image build fails. |
The failures in native are caused by Compilation into native image works fine when I comment out the dependency - @jsmrcka please file the GH issue in the Quarkus repo, CC @Sgitario Native image build fail is imho related to the dynamically generate methods available in
|
Another interesting fact is that spring-data module receive similar changes but the compilation into native works fine. |
6f816de
to
16687bf
Compare
Native failure reported: Native build of the
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, check CI checkstyle validation errors!
...a/src/test/java/io/quarkus/ts/spring/data/rest/secured/SecuredRepositoryRestResourcesIT.java
Outdated
Show resolved
Hide resolved
Reported here: quarkusio/quarkus#30540. EDIT: fixed. |
Quarkus extensions based on `rest-data-panache` support propagation of security annotations into generated JAX-RS resources. These tests provide coverage of this feature for extensions: - `quarkus-hibernate-orm-rest-data-panache` - `quarkus-spring-data-rest` See also related test plan: - https://github.com/quarkus-qe/quarkus-test-plans/blob/main/QUARKUS-2788.md
16687bf
to
fc9a4b6
Compare
run tests |
1 similar comment
run tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but let's hold this PR until having a look OCP results
Quarkus extensions based on `rest-data-panache` support propagation of security annotations into generated JAX-RS resources. These tests provide coverage of this feature for extensions: - `quarkus-hibernate-orm-rest-data-panache` - `quarkus-spring-data-rest` See also related test plan: - https://github.com/quarkus-qe/quarkus-test-plans/blob/main/QUARKUS-2788.md (cherry picked from commit 3f7a4c8)
Quarkus extensions based on `rest-data-panache` support propagation of security annotations into generated JAX-RS resources. These tests provide coverage of this feature for extensions: - `quarkus-hibernate-orm-rest-data-panache` - `quarkus-spring-data-rest` See also related test plan: - https://github.com/quarkus-qe/quarkus-test-plans/blob/main/QUARKUS-2788.md (cherry picked from commit 3f7a4c8)
… modules (#1021) * Test Extended Architecture (XA) connection Provides coverage for https://issues.redhat.com/browse/QUARKUS-2742 (cherry picked from commit ce15b26) * Improve reactive rest client "process paths before sub resources" scenario (#995) There is an issue in upstream (quarkusio/quarkus#29821) that only happens under some RestClient definition hierarchy. This commit reproduces the problem in Quarkus 2.12 and earlier versions (cherry picked from commit 2350b46) * New Scenario: RequestScope custom context was removed after `javax.enterprise` event propagation When firing an async CDI Event, the requestScope context from the emitter briefly exists for the observer and is then terminated. This commit is a reproducer of this scenario that happens on Quarkus 2.13.0.Final (cherry picked from commit ef3eed6) * gRPC and SSE coverage for OpenTelemetry (cherry picked from commit f327c60) * Add coverage to eventbus '@ConsumeEvent' annotation (cherry picked from commit 7da0d4b) * Drop duplicated definition of quarkus-opentelemetry (cherry picked from commit b0cba7f) * OutboundSseEvent is not correctly serialized (cherry picked from commit 99b5eb1) * Check, that dev-mode is omitted on projects with pom packaging Required for QUARKUS-2757 (cherry picked from commit 4fd38c7) * Refactoring of QUARKUS-2748: adding http test and improving error messages (cherry picked from commit 6563431) * Add test for security annotations in rest-data-panache (#994) Quarkus extensions based on `rest-data-panache` support propagation of security annotations into generated JAX-RS resources. These tests provide coverage of this feature for extensions: - `quarkus-hibernate-orm-rest-data-panache` - `quarkus-spring-data-rest` See also related test plan: - https://github.com/quarkus-qe/quarkus-test-plans/blob/main/QUARKUS-2788.md (cherry picked from commit 3f7a4c8) * Add transaction-API classic scenario (cherry picked from commit 509d491) * Cover Vert.X-specific metrics. (#1019) Add new module, which uses Vert.X-based HTTP server Verify, that it works, and that it creates all required metrics Required for https://issues.redhat.com/browse/QUARKUS-2829 (cherry picked from commit 818837f) * Add missing opentelemetry exporter to Narayana scenario --------- Co-authored-by: Fedor Dudinskiy <[email protected]> Co-authored-by: Rostislav Svoboda <[email protected]> Co-authored-by: Josef Smrcka <[email protected]>
Summary
Quarkus extensions based on
rest-data-panache
support propagation of security annotations into generated JAX-RS resources. These tests provide coverage of this feature for extensions:quarkus-hibernate-orm-rest-data-panache
quarkus-spring-data-rest
See also related test plan:
Please select the relevant options.
run tests
phrase in comment)Checklist: