Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test coverage for some 3.8.5 backports 2 #40663 #1802

Merged
merged 3 commits into from
Jun 6, 2024
Merged

Add test coverage for some 3.8.5 backports 2 #40663 #1802

merged 3 commits into from
Jun 6, 2024

Conversation

jcarranzan
Copy link
Contributor

@jcarranzan jcarranzan commented May 21, 2024 •
edited
Loading

Summary

Adding TD for the next backports:

Please select the relevant options.

  • Bug fix (non-breaking change which fixes an issue)
  • Dependency update
  • Refactoring
  • Backport
  • New scenario (non-breaking change which adds functionality)
  • This change requires a documentation update
  • This change requires execution against OCP (use run tests phrase in comment)

Checklist:

  • Methods and classes used in PR scenarios are meaningful
  • Commits are well encapsulated and follow the best practices

@jcarranzan jcarranzan requested a review from fedinskiy May 21, 2024 10:42
@github-actions github-actions bot added the triage/flaky-test Signal that flaky tests were detected during CI run label May 21, 2024
@github-actions GitHub Actions
Copy link

Following jobs contain at least one flaky test: 'PR - Linux - JVM build - Latest Version'

@jcarranzan jcarranzan force-pushed the 3.8.5-backports branch 2 times, most recently from d86f3bc to 16db8ab Compare May 23, 2024 11:46
@jcarranzan jcarranzan marked this pull request as ready for review May 23, 2024 11:46
@jcarranzan
Copy link
Contributor Author

Issue related to the backport (Properly convert MemorySize to RESTEasy configuration with
quarkus.resteasy.gzip.max-input) --> quarkusio/quarkus#40806

@michalvavrik
Copy link
Member

michalvavrik commented May 23, 2024 •
edited
Loading

@jcarranzan PR title is not helpful, I really thought you are doing backport and was thinking hey, PR description doesn't add up. Please fix the title to properly describe what this PR is about. Fact that you marked this PR as backport doesn't help either.

@jcarranzan jcarranzan changed the title 3.8.5 backports 2 #40663 Add test coverage for some 3.8.5 backports 2 #40663 May 23, 2024
@jcarranzan jcarranzan requested a review from fedinskiy May 23, 2024 19:51
fedinskiy
fedinskiy requested changes May 27, 2024
View reviewed changes
Copy link
Contributor

@fedinskiy fedinskiy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, check the CI

quarkus-cli/src/test/java/io/quarkus/ts/quarkus/cli/QuarkusCliPomIntegrityIT.java Outdated Show resolved Hide resolved
http/rest-client/src/test/java/io/quarkus/ts/http/restclient/GzipMaxInputIT.java Outdated Show resolved Hide resolved
http/rest-client/src/test/java/io/quarkus/ts/http/restclient/GzipMaxInputIT.java Outdated Show resolved Hide resolved
@jcarranzan jcarranzan force-pushed the 3.8.5-backports branch 6 times, most recently from 57156a3 to ec54147 Compare May 27, 2024 12:31
@jcarranzan jcarranzan requested a review from fedinskiy May 27, 2024 12:45
@jcarranzan
Copy link
Contributor Author

I've opened an issue related to the backport of POM preserved after add/remove extension--> quarkusio/quarkus#40853

@jcarranzan jcarranzan requested a review from fedinskiy May 28, 2024 07:54
@jcarranzan
Add coverage for max parameters of multipart
19de745 
tweak mulripart tests

fix for loop initial from 0
rsvoboda
rsvoboda requested changes Jun 3, 2024
View reviewed changes
Copy link
Member

@rsvoboda rsvoboda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to followup on the GH issue

@rsvoboda rsvoboda requested a review from fedinskiy June 4, 2024 11:25
@rsvoboda
Copy link
Member

rsvoboda commented Jun 4, 2024

@jcarranzan squash relevant changes togetger

If not sure how to do it, please check https://stackoverflow.com/questions/24310554/how-do-i-squash-specific-commits-on-a-local-branch or some videos on YT.

Also why bumping the limit to 100 MB?

I will check the code later today or tmr, depends how long the planned meetings take.

@jcarranzan
Copy link
Contributor Author

@jcarranzan squash relevant changes togetger

* [df00615](https://github.com/quarkus-qe/quarkus-test-suite/commit/df006154d06da833835790a6892b4c749805c2a1) and [43e5735](https://github.com/quarkus-qe/quarkus-test-suite/commit/43e5735d9b66421224df9eadcf88c653255e346e)

* [5a04d65](https://github.com/quarkus-qe/quarkus-test-suite/commit/5a04d659f3a6fa67aa0987cbd9d4c532b940de26) and [6ae6f6d](https://github.com/quarkus-qe/quarkus-test-suite/commit/6ae6f6d253ff00f8a5e6559542677bee635598ff)

If not sure how to do it, please check https://stackoverflow.com/questions/24310554/how-do-i-squash-specific-commits-on-a-local-branch or some videos on YT.

Also why bumping the limit to 100 MB?

I will check the code later today or tmr, depends how long the planned meetings take.

Hi @rsvoboda ,
I set the limit to 100MB to verify that the fix of the issue quarkusio/quarkus#39636 was properly addressed, and (FMHO) it's still valid for my previous test coverage of quarkus.resteasy.gzip.max-input.
Also I've squashed the commits as you asked me.
Thank you for your suggestions.

@jcarranzan
Add test coverage of 'resteasy.gzip.max-input' property
d5668f6 
add test with bigger bytes

add proper boundary limits for cover testing of 'quarkus.resteasy.gzip.max-input=1k' property

tweak gzip tests
@jcarranzan
Add test coverage for POM format when extensions are added/removed'
fc22651 
fix style

remove @disable test already fix quarkusio/quarkus#40869

rm Disable import
@jcarranzan jcarranzan requested a review from rsvoboda June 5, 2024 08:23
@rsvoboda
Copy link
Member

rsvoboda commented Jun 6, 2024

CI failures in CLI module are not related to this, there is work in progress to address them.

@rsvoboda rsvoboda merged commit 190565e into quarkus-qe:main Jun 6, 2024
7 of 9 checks passed
@fedinskiy fedinskiy mentioned this pull request Jun 6, 2024
Merged
9 tasks
@jcarranzan jcarranzan mentioned this pull request Jun 12, 2024
Merged
9 tasks
@michalvavrik michalvavrik deleted the 3.8.5-backports branch November 20, 2024 10:25
@michalvavrik michalvavrik removed the triage/flaky-test Signal that flaky tests were detected during CI run label Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michalvavrik michalvavrik michalvavrik left review comments

@rsvoboda rsvoboda rsvoboda approved these changes

@fedinskiy fedinskiy Awaiting requested review from fedinskiy

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jcarranzan @michalvavrik @rsvoboda @fedinskiy @jedla97