Skip to content

Commit

Permalink
Add test coverage for POM format when extensions are added/removed'
Browse files Browse the repository at this point in the history
fix style
  • Loading branch information
jcarranzan committed May 28, 2024
1 parent 9e8f1a4 commit 31d5408
Show file tree
Hide file tree
Showing 2 changed files with 54 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,7 @@ void testGzipOverTheMaxLimit() throws IOException {
assertEquals(HttpStatus.SC_REQUEST_TOO_LONG, response.statusCode());
}

@Disabled ("Because https://github.com/quarkusio/quarkus/issues/40806")
@Disabled("Because https://github.com/quarkusio/quarkus/issues/40806")
@Test
void testGzipBelowMaxLimit() throws IOException {
byte[] compressedData = generateCompressedData(gzip_bellow_1K_limit_max);
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,53 @@
package io.quarkus.ts.quarkus.cli;

import java.io.IOException;
import java.nio.file.Files;
import java.nio.file.Path;
import java.nio.file.Paths;
import java.util.List;

import jakarta.inject.Inject;

import org.junit.jupiter.api.Assertions;
import org.junit.jupiter.api.Disabled;
import org.junit.jupiter.api.Test;

import io.quarkus.test.bootstrap.QuarkusCliClient;
import io.quarkus.test.bootstrap.QuarkusCliRestService;
import io.quarkus.test.scenarios.QuarkusScenario;

@QuarkusScenario
public class QuarkusCliPomIntegrityIT {
/*
* This scenario is related to the backport https://github.com/quarkusio/quarkus/issues/39088
*
*/
private static final String NEW_EXTENSION = "quarkus-kafka-client";
private static final String COMMENT = "<!-- Disable native build on this module -->";

private static final String APP_NAME = "my-quarkus-app";

@Inject
static QuarkusCliClient cliClient;

@Disabled
@Test
public void shouldKeepCommentInPomAfterAddAndRemoveExtension() throws IOException {
final Path POM_PATH = Paths.get("target", QuarkusCliPomIntegrityIT.class.getSimpleName(), APP_NAME, "pom.xml");
QuarkusCliRestService app = cliClient.createApplication("my-quarkus-app",
QuarkusCliClient.CreateApplicationRequest.defaults());

List<String> initialPomContent = Files.readAllLines(POM_PATH);
initialPomContent.add(1, COMMENT);

// Add extension
app.installExtension(NEW_EXTENSION);
List<String> updatedPomContent = Files.readAllLines(POM_PATH);
Assertions.assertTrue(updatedPomContent.contains(COMMENT), "The comment after add extension still should be there");

// Remove extension
app.removeExtension(NEW_EXTENSION);
List<String> finalPomContent = Files.readAllLines(POM_PATH);
Assertions.assertTrue(finalPomContent.contains(COMMENT), "The comment after remove extension still should be there");
}
}

0 comments on commit 31d5408

Please sign in to comment.