Value refactorings - split into separate files #2978
Conversation
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
| dateFormat?: VString; // can be set on dates | ||
| hidden?: VBool; | ||
| notebook?: VBool; // can be set on arrays | ||
| exportData?: VDict; // should be { sourceId: String, path: List(String) } |
There was a problem hiding this comment.
maybe when we eventually have Structs, we could use them here. Not sure though.
There was a problem hiding this comment.
Yep, I mentioned this idea in description
|
Seems like a good direction, though I agree the lack of type safety is annoying. |
As we discussed in https://discord.com/channels/1130609991993274510/1133551706370752582/1196297279359959150, I had to convert
ValueTagsTypefrom plain values toValueobjects, because of circular imports issue.Because of this, some things became less type-safe (
startOpenStatein particular). I'm not very happy about it, but I hope that we will clean this up after custom structs — then we could have some common infra for validating typed Squiggle dicts.