Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds Tag.startOpen, Tag.startClosed, Tag.getStartOpenState #2975

Merged
merged 5 commits into from
Jan 17, 2024
Merged

Conversation

OAGr
Copy link
Contributor

@OAGr OAGr commented Jan 17, 2024

Closes #2959

@OAGr OAGr requested a review from berekuk as a code owner January 17, 2024 04:51
Copy link

changeset-bot bot commented Jan 17, 2024

🦋 Changeset detected

Latest commit: e0ce8cd

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 6 packages
Name Type
@quri/squiggle-lang Patch
@quri/squiggle-components Patch
@quri/prettier-plugin-squiggle Patch
@quri/versioned-squiggle-components Patch
vscode-squiggle Patch
@quri/squiggle-textmate-grammar Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Jan 17, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
quri-hub ✅ Ready (Inspect) Visit Preview Jan 17, 2024 9:16pm
squiggle-components ✅ Ready (Inspect) Visit Preview Jan 17, 2024 9:16pm
squiggle-website ✅ Ready (Inspect) Visit Preview Jan 17, 2024 9:16pm
1 Ignored Deployment
Name Status Preview Updated (UTC)
quri-ui ⬜️ Ignored (Inspect) Visit Preview Jan 17, 2024 9:16pm

testEvalToBe("3 -> Tag.startOpen -> Tag.getStartOpenState", '"open"');
testEvalToBe("3 -> Tag.startClosed -> Tag.getStartOpenState", '"closed"');
testEvalToBe(
"3 -> Tag.startClosed -> Tag.startOpen -> Tag.getStartOpenState",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small feature that one can do "startClosed" then "startOpen", and the last one is what counts. This wouldn't be the case if we saved both separately.

packages/squiggle-lang/src/fr/tag.ts Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

@beginClosed and @beginOpen tags
2 participants