-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Common tsconfigs #2947
Common tsconfigs #2947
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Happy to see this fixed! It works on my machine, which is the main thing I was looking for. Code roughly looks good to me, though I don't understand some of the TSConfig so well.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2947 +/- ##
==========================================
+ Coverage 69.78% 69.81% +0.03%
==========================================
Files 120 120
Lines 6781 6782 +1
Branches 1446 1446
==========================================
+ Hits 4732 4735 +3
+ Misses 2041 2039 -2
Partials 8 8 ☔ View full report in Codecov by Sentry. |
Seems like this broke Squiggle Hub. I rolled back via Vercel. |
New configs are stored in
packages/configs
(@quri/configs
internal package).There are two configs, one for most packages (
tsconfig.base.json
) and another for Next.js apps (tsconfig.nextjs.json
).Packages still have to define
rootDir
andoutDir
, because of microsoft/TypeScript#29172.This PR also fixes #2684 by storing tsbuildinfo file in a different location.
Other changes:
squiggle-lang
but not in other packages is now a common setting; this means that e.g.process.env.FOO
now needs to beprocess.env["FOO"]
override
keyword inErrorBoundary
components, but otherwise didn't affect anythingtarget
(ES version) might be slightly different than before, for some packages, but I hope it won't break anything