Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

usePreloadedQuery - should make squigglehub faster #2131

Merged
merged 3 commits into from
Jul 30, 2023
Merged

Conversation

berekuk
Copy link
Collaborator

@berekuk berekuk commented Jul 30, 2023

@changeset-bot
Copy link

changeset-bot bot commented Jul 30, 2023

⚠️ No Changeset found

Latest commit: b307460

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Jul 30, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
quri-hub ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 30, 2023 6:25pm
3 Ignored Deployments
Name Status Preview Comments Updated (UTC)
quri-ui ⬜️ Ignored (Inspect) Visit Preview Jul 30, 2023 6:25pm
squiggle-components ⬜️ Ignored (Inspect) Visit Preview Jul 30, 2023 6:25pm
squiggle-website ⬜️ Ignored (Inspect) Visit Preview Jul 30, 2023 6:25pm

@berekuk
Copy link
Collaborator Author

berekuk commented Jul 30, 2023

This is ready. No /api/graphql queries on client side on page load, feels significantly faster.

The pattern for loading data in Next.js pages is a bit verbose, so I added some documentation notes.

Loading states are still there; my understanding is that in many cases Next.js is able to load some parts of the UI immediately thanks to suspense and streaming, so it works as intended. The client waits for the server to send page contents, but doesn't hit the API itself.

Copy link
Contributor

@OAGr OAGr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like things load a fair bit faster, happy to see that.

Most of the code seems like it's just adding this pattern around. I'm trusting you on this pattern.

@OAGr OAGr merged commit 8e7a4b0 into main Jul 30, 2023
3 checks passed
@OAGr OAGr deleted the relay-improvements branch July 30, 2023 23:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants