[cpullvm] Add an xqci variant as part of libc++ tests - #620
Merged
Jonathon Penix (jonathonpenix) merged 4 commits intoAug 24, 2026
Merged
Jonathon Penix (jonathonpenix) merged 4 commits into
Jonathon Penix (jonathonpenix) merged 4 commits into
Conversation
Previously, xqci variants were omitted as we saw huge numbers of libc++ test failures in variants without 'a' (see qualcomm#469) and at the time we didn't have any xqci variants with 'a'. We do now (and these variants turn on C++ libs and `ENABLE_LIBCXX_TESTS`) so add one such variant in the scheduled libc++ tests--it should be clean. Signed-off-by: Jonathon Penix <jpenix@qti.qualcomm.com>
Signed-off-by: Jonathon Penix <jpenix@qti.qualcomm.com>
Signed-off-by: Jonathon Penix <jpenix@qti.qualcomm.com>
This reverts commit 209c6c8.
Contributor
Author
|
Successful run of c++ tests: https://github.com/qualcomm/cpullvm-toolchain/actions/runs/32618268207/job/97142376093?pr=620 |
Jonathon Penix (jonathonpenix)
marked this pull request as ready for review
August 23, 2026 18:28
Ana Pazos (apazos)
approved these changes
Aug 23, 2026
Ana Pazos (apazos)
left a comment
Ana Pazos (apazos)
left a comment
Contributor
There was a problem hiding this comment.
Thanks Jonathon Penix (@jonathonpenix) for enabling this config now that there is a variant with atomics enabled.
Jonathon Penix (jonathonpenix)
merged commit Aug 24, 2026
1366273
into
qualcomm:qualcomm-software
13 of 14 checks passed
Contributor
Author
|
/cherry-pick 1366273 |
Collaborator
|
/pull-request #622 |
Jonathon Penix (jonathonpenix)
added a commit
that referenced
this pull request
Aug 25, 2026
… of libc++ tests (#620) (#622) Backport 1366273 Requested by: @jonathonpenix Signed-off-by: Jonathon Penix <jpenix@qti.qualcomm.com> Co-authored-by: Jonathon Penix <jpenix@qti.qualcomm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, xqci variants were omitted as we saw huge numbers of libc++ test
failures in variants without 'a' (see #469)
and at the time we didn't have any xqci variants with 'a'.
We do now (and these variants turn on C++ libs and
ENABLE_LIBCXX_TESTS) soadd one such variant in the scheduled libc++ tests--it should be clean.