[cpullvm] Add armv7m -mfpu=fpv5-d16 hard float variant#352
Merged
jonathonpenix merged 8 commits intoMay 21, 2026
Merged
Conversation
The intention here is to offer a variant for Cortex M7 users with fpv5-d16 enabled. There's a few misc. things to note here: - The normalized triple clang uses when `-mcpu=cortex-m7` is used is actually along the lines of `thumbv7em*` rather than the `thumb7m` we use here. Our `multilib.yaml.in` has mappings for these which we inherited from ATfE. So, align with what their configs seem to do and stick with thumbv7m. - Picolibc is the only libc we want to support for this variant--a musl-embedded variant is intentionally omitted as we're moving away from musl-embedded. - This variant is built with PIC in keeping with our other 32bit Arm variants (where the nopic ones were late/special additions). - We build our other armv7m configurations with `-mno-unaligned-access` (and we don't have both aligned and unaligned variants like ATfE). I'm following suit here under the assumption it is a safe default, though I'm not entirely clear what is supported for our user. Signed-off-by: Jonathon Penix <jpenix@qti.qualcomm.com>
Discussing with Ana, sounds like we know that the user isn't using PIC and we've had issues with 32bit Arm fPIC variants + Zephyr + eld in the past (see qualcomm#309). So let's make this nopic Signed-off-by: Jonathon Penix <jpenix@qti.qualcomm.com>
Discussing with Ana, the relevant build is resolving to -munaligned-access. So don't force -mno-unaligned-access for the variant Signed-off-by: Jonathon Penix <jpenix@qti.qualcomm.com>
Signed-off-by: Jonathon Penix <jpenix@qti.qualcomm.com>
Signed-off-by: Jonathon Penix <jpenix@qti.qualcomm.com>
Contributor
Author
|
Version of #351 in the 22.x branch |
Signed-off-by: Jonathon Penix <jpenix@qti.qualcomm.com>
apazos
approved these changes
May 21, 2026
jonathonpenix
merged commit e0b5a4f
into
qualcomm:release/qualcomm-software/22.x
8 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The intention here is to offer a variant for Cortex M7 users with fpv5-d16 enabled.
There's a few misc. things to note here:
-mcpu=cortex-m7is used is actually along the lines ofthumbv7em*rather than thethumb7mwe use here. Ourmultilib.yaml.inhas mappings for these which we inherited from ATfE. So, align with what their configs seem to do and stick with thumbv7m.-mno-unaligned-access(and we don't have both aligned and unaligned variants like ATfE). But, the relevant user build here is resolving to-munaligned-accessso I'm not going to force-mno-unaligned-accessin the library build unless we have a particular need.