layouts: Remove my ergodox keymap #4465
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The keymap is currently broken (too big), and as I'm not using it anymore, it is unlikely to get updated or even fixed anytime soon. As such, I feel it is best to remove it. Signed-off-by: Gergely Nagy <[email protected]>
|
Honestly, I'm not a fan of removing it. There is a lot of good stuff there that could be used for reference (or in at least one case already, bugchecking). But if that's what you want... |
|
Well, yeah.. there's some interesting stuff there. Hm. I can remove the PLOVER and ADORE layers (the least interesting bits, I guess... or keep ADORE and remove DVORAK, 'cos ADORE is funky), that should free up enough space to let the keymap compile. In this case, I'd also update the readme that comes with the keymap to note that it's just there to borrow ideas from, and isn't actively used or developed anymore. |
|
Oh. I can just disable RGBLIGHT and solve all issues. I'll just submit the latest version of my keymap then. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The keymap is currently broken (too big), and as I'm not using it anymore, it is unlikely to get updated or even fixed anytime soon. As such, I feel it is best to remove it.
(This PR was surprisingly hard to write... 😭)