Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Ergodox EZ Matrix scan #4458

Merged
merged 1 commit into from
Nov 22, 2018
Merged

Fix Ergodox EZ Matrix scan #4458

merged 1 commit into from
Nov 22, 2018

Conversation

drashna
Copy link
Member

@drashna drashna commented Nov 21, 2018

Specifically, row 11 was wrong.

Thanks algernon, for catching that.

@mechmerlin mechmerlin added the bug label Nov 21, 2018
@ezuk
Copy link
Contributor

ezuk commented Nov 21, 2018

@fdidron thoughts?

@fdidron
Copy link
Contributor

fdidron commented Nov 21, 2018

@ezuk @drashna looks good to me.

@algernon
Copy link
Contributor

I think I figured out why the keyboard works either way: PORTD doesn't appear to matter, only DDRD. According to the comments in unselect_row and select_row, the port bit is always zero. With that in mind, the whole code could be simplified by removing the PORT settings alltogether (and just zeroing them on matrix_init, which unselect_row already does).

@ezuk ezuk merged commit b7dd415 into qmk:master Nov 22, 2018
@drashna drashna deleted the ergodox_ez_matrix_fix branch November 22, 2018 15:58
@ezuk
Copy link
Contributor

ezuk commented Nov 22, 2018

@algernon on a semi-related note: I think your keymap might be breaking CI right now? :) Did you happen to notice?

@algernon
Copy link
Contributor

I did, #4465 was submitted as a result.

@ezuk
Copy link
Contributor

ezuk commented Nov 23, 2018

@algernon amazing! 😻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants