Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve string sending #376

Merged
merged 1 commit into from
Jun 3, 2016
Merged

Improve string sending #376

merged 1 commit into from
Jun 3, 2016

Conversation

eltang
Copy link
Contributor

@eltang eltang commented Jun 3, 2016

  • Move strings and LUTs to flash in order to reduce RAM consumption
  • Rename LUTs for clarity
  • Split lines longer than 80 characters

@eltang
Copy link
Contributor Author

eltang commented Jun 3, 2016

This check stuff is fancy.

@jackhumbert jackhumbert merged commit 794aed3 into qmk:master Jun 3, 2016
@jackhumbert
Copy link
Member

Cool, thanks. Let's skip the reformatting (line splitting) stuff in the future - it's just pedantic and not needed. Also, renaming should really be up to the collaborators.

@eltang
Copy link
Contributor Author

eltang commented Jun 3, 2016 •
edited
Loading

All right, but didn't you say you liked code to be readable?

@eltang eltang deleted the string_sending_fix branch June 3, 2016 19:56
@eltang eltang mentioned this pull request Jun 3, 2016
Closed
ryaninvents pushed a commit to ryaninvents/qmk_firmware that referenced this pull request Aug 12, 2016
@eltang @jackhumbert
Improve string sending (qmk#376)
18c012a
jiaxin96 pushed a commit to Oh-My-Mechanical-Keyboard/qmk_firmware that referenced this pull request Oct 18, 2023
@lesshonor
Revert "Add Vial keymap for gmmk/pro/rev2/ansi (qmk#299)" (qmk#376)
c99b885 
This reverts commit 760adce.
KarlK90 added a commit to KarlK90/qmk_firmware that referenced this pull request Nov 28, 2023
@KarlK90
lib: chibios-contrib: sync with chibios-21.11.x
ac0a680 
This contains commit from da78eb3759b8..9d7a7f904ed1:

    9d7a7f90 Merge pull request qmk#382 from KarlK90/fix/rp2040-i2c-speeds
    70119934 Merge pull request qmk#383 from
             KarlK90/fix/rp2040-usb-get-status-request
    1a1bbe6c rp2040: usb: fix usb_lld_get_status functions
    7d9212dd rp2040: i2c: fix speed calculation
    fb67e502 Merge pull request qmk#377 from 1Conan/sn32_fix_registry
    e72939ef SN32: update registry
    5b4836ca Merge pull request qmk#376 from dexter93/sn32_usb_v2
    5ded9de9 sn32: usb: do NOT clear interrupt status until handled
    Leftover Sonix reference code cleanup. Sometimes when there is
    traffic on more than 1 ep's packets would be dropped before they
    could be handled. Clearing the status flags after handling them
    takes care of it.
    e9a4a512 sn32: usb: only activate interrupts on lld start
    e4a35d1c sn32: fix host remote wakeup
KarlK90 added a commit that referenced this pull request Nov 29, 2023
@KarlK90
lib: chibios-contrib: sync with chibios-21.11.x (#22560)
36ad597 
This contains commit from da78eb3759b8..9d7a7f904ed1:

    9d7a7f90 Merge pull request #382 from KarlK90/fix/rp2040-i2c-speeds
    70119934 Merge pull request #383 from
             KarlK90/fix/rp2040-usb-get-status-request
    1a1bbe6c rp2040: usb: fix usb_lld_get_status functions
    7d9212dd rp2040: i2c: fix speed calculation
    fb67e502 Merge pull request #377 from 1Conan/sn32_fix_registry
    e72939ef SN32: update registry
    5b4836ca Merge pull request #376 from dexter93/sn32_usb_v2
    5ded9de9 sn32: usb: do NOT clear interrupt status until handled
    Leftover Sonix reference code cleanup. Sometimes when there is
    traffic on more than 1 ep's packets would be dropped before they
    could be handled. Clearing the status flags after handling them
    takes care of it.
    e9a4a512 sn32: usb: only activate interrupts on lld start
    e4a35d1c sn32: fix host remote wakeup
leotaku pushed a commit to leotaku/qmk_firmware that referenced this pull request Dec 1, 2023
@drashna
fix: voyager led array config (qmk#376)
91d91a8
nuess0r pushed a commit to nuess0r/qmk_firmware that referenced this pull request Sep 8, 2024
@KarlK90 @nuess0r
lib: chibios-contrib: sync with chibios-21.11.x (qmk#22560)
21ba3a4 
This contains commit from da78eb3759b8..9d7a7f904ed1:

    9d7a7f90 Merge pull request qmk#382 from KarlK90/fix/rp2040-i2c-speeds
    70119934 Merge pull request qmk#383 from
             KarlK90/fix/rp2040-usb-get-status-request
    1a1bbe6c rp2040: usb: fix usb_lld_get_status functions
    7d9212dd rp2040: i2c: fix speed calculation
    fb67e502 Merge pull request qmk#377 from 1Conan/sn32_fix_registry
    e72939ef SN32: update registry
    5b4836ca Merge pull request qmk#376 from dexter93/sn32_usb_v2
    5ded9de9 sn32: usb: do NOT clear interrupt status until handled
    Leftover Sonix reference code cleanup. Sometimes when there is
    traffic on more than 1 ep's packets would be dropped before they
    could be handled. Clearing the status flags after handling them
    takes care of it.
    e9a4a512 sn32: usb: only activate interrupts on lld start
    e4a35d1c sn32: fix host remote wakeup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eltang @jackhumbert