Color output during make #383
Comments
|
As long as there's both a way to turn it off and it's smart enough to only colorize output when stdout is a tty, I don't see any reasons for not doing it. (I don't think it helps much, personally, but lots of people seem to benefit from color.) |
|
Added this at a785b00 for messing around with - really only does the warnings/errors, but is useful to see what's wrong. Haven't added the conditional to it yet. |
|
Oooh, colors! 🌈 |
|
Here's a preview of the make reformatting: |
|
Super nice. Very clear. Makes me want to fix all the warnings :) |
|
Merged in from #395! |
BlueTufa
pushed a commit
to BlueTufa/qmk_firmware
that referenced
this issue
Aug 6, 2021
* adding i18n to print * reference fix + lint * lint * Update src/views/Print.vue Co-Authored-By: noroadsleft <[email protected]> * review
KarlK90
added a commit
to KarlK90/qmk_firmware
that referenced
this issue
Nov 28, 2023
This contains commit from da78eb3759b8..9d7a7f904ed1:
9d7a7f90 Merge pull request qmk#382 from KarlK90/fix/rp2040-i2c-speeds
70119934 Merge pull request qmk#383 from
KarlK90/fix/rp2040-usb-get-status-request
1a1bbe6c rp2040: usb: fix usb_lld_get_status functions
7d9212dd rp2040: i2c: fix speed calculation
fb67e502 Merge pull request qmk#377 from 1Conan/sn32_fix_registry
e72939ef SN32: update registry
5b4836ca Merge pull request qmk#376 from dexter93/sn32_usb_v2
5ded9de9 sn32: usb: do NOT clear interrupt status until handled
Leftover Sonix reference code cleanup. Sometimes when there is
traffic on more than 1 ep's packets would be dropped before they
could be handled. Clearing the status flags after handling them
takes care of it.
e9a4a512 sn32: usb: only activate interrupts on lld start
e4a35d1c sn32: fix host remote wakeup
KarlK90
added a commit
that referenced
this issue
Nov 29, 2023
This contains commit from da78eb3759b8..9d7a7f904ed1:
9d7a7f90 Merge pull request #382 from KarlK90/fix/rp2040-i2c-speeds
70119934 Merge pull request #383 from
KarlK90/fix/rp2040-usb-get-status-request
1a1bbe6c rp2040: usb: fix usb_lld_get_status functions
7d9212dd rp2040: i2c: fix speed calculation
fb67e502 Merge pull request #377 from 1Conan/sn32_fix_registry
e72939ef SN32: update registry
5b4836ca Merge pull request #376 from dexter93/sn32_usb_v2
5ded9de9 sn32: usb: do NOT clear interrupt status until handled
Leftover Sonix reference code cleanup. Sometimes when there is
traffic on more than 1 ep's packets would be dropped before they
could be handled. Clearing the status flags after handling them
takes care of it.
e9a4a512 sn32: usb: only activate interrupts on lld start
e4a35d1c sn32: fix host remote wakeup
nuess0r
pushed a commit
to nuess0r/qmk_firmware
that referenced
this issue
Sep 8, 2024
This contains commit from da78eb3759b8..9d7a7f904ed1:
9d7a7f90 Merge pull request qmk#382 from KarlK90/fix/rp2040-i2c-speeds
70119934 Merge pull request qmk#383 from
KarlK90/fix/rp2040-usb-get-status-request
1a1bbe6c rp2040: usb: fix usb_lld_get_status functions
7d9212dd rp2040: i2c: fix speed calculation
fb67e502 Merge pull request qmk#377 from 1Conan/sn32_fix_registry
e72939ef SN32: update registry
5b4836ca Merge pull request qmk#376 from dexter93/sn32_usb_v2
5ded9de9 sn32: usb: do NOT clear interrupt status until handled
Leftover Sonix reference code cleanup. Sometimes when there is
traffic on more than 1 ep's packets would be dropped before they
could be handled. Clearing the status flags after handling them
takes care of it.
e9a4a512 sn32: usb: only activate interrupts on lld start
e4a35d1c sn32: fix host remote wakeup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Are there any good reasons for not doing this? It could make things a bit more informative.
The text was updated successfully, but these errors were encountered: