Skip to content

Support networkx.Graphs as input to Lattice#472

Merged
mergify[bot] merged 7 commits into
qiskit-community:mainfrom
Cryoris:lattice-networkx-support
Feb 15, 2022
Merged

Support networkx.Graphs as input to Lattice#472
mergify[bot] merged 7 commits into
qiskit-community:mainfrom
Cryoris:lattice-networkx-support

Conversation

@Cryoris
Copy link
Copy Markdown
Contributor

@Cryoris Cryoris commented Dec 20, 2021

Summary

Closes #465.

Details and comments

Split 2/2 of PR #467.

Copy link
Copy Markdown
Member

@mrossinek mrossinek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This already looks good. I will review this properly once #471 is merged, since this is blocked by that PR.

Copy link
Copy Markdown
Member

@mrossinek mrossinek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not have a real opinion on this but I guess more options are good for users. Once the CI passes I am fine with merging this 👍

But @pbark should review this as he has more knowledge about the lattice module.

@Cryoris
Copy link
Copy Markdown
Contributor Author

Cryoris commented Feb 1, 2022

I'm highly confused by this spell check error. Does anyone have an idea what the following means? (See changed files tab)
image

Edit: I tried to resolve it by rebasing all commits in one, I guess it picked up a spelling mistake from a previous commit (why? no clue!)

@Cryoris Cryoris force-pushed the lattice-networkx-support branch from cce0bc1 to 16a649b Compare February 1, 2022 16:59
@coveralls
Copy link
Copy Markdown

coveralls commented Feb 1, 2022

Pull Request Test Coverage Report for Build 1846266906

  • 7 of 7 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.02%) to 82.953%

Totals Coverage Status
Change from base Build 1845564505: 0.02%
Covered Lines: 8696
Relevant Lines: 10483

💛 - Coveralls

Comment thread qiskit_nature/problems/second_quantization/lattice/lattices/lattice.py Outdated
Comment thread qiskit_nature/problems/second_quantization/lattice/lattices/lattice.py Outdated
Comment thread qiskit_nature/problems/second_quantization/lattice/lattices/lattice.py Outdated
mrossinek
mrossinek previously approved these changes Feb 9, 2022
mrossinek
mrossinek previously approved these changes Feb 9, 2022
mrossinek
mrossinek previously approved these changes Feb 9, 2022
Copy link
Copy Markdown
Contributor

@ikkoham ikkoham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks

@mergify mergify Bot merged commit ab2ac27 into qiskit-community:main Feb 15, 2022
@Cryoris Cryoris deleted the lattice-networkx-support branch February 18, 2022 16:32
Anthony-Gandon pushed a commit to Anthony-Gandon/qiskit-nature that referenced this pull request May 25, 2023
…#472)

* Lattice from networkx support

* use lazy loaders for NX

* skip test if NX not available

* lint

* lint once more :)

Co-authored-by: Manoel Marques <Manoel.Marques@ibm.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Initialize Lattices with networkx.Graphs

5 participants