Skip to content

Typechecking edge weights of input graphs to Lattice#471

Closed
Cryoris wants to merge 14 commits into
qiskit-community:mainfrom
Cryoris:lattice-edge-typecheck
Closed

Typechecking edge weights of input graphs to Lattice#471
Cryoris wants to merge 14 commits into
qiskit-community:mainfrom
Cryoris:lattice-edge-typecheck

Conversation

@Cryoris
Copy link
Copy Markdown
Contributor

@Cryoris Cryoris commented Dec 20, 2021

Summary

Closes #466.

Details and comments

Split 1/2 of PR #467.

Cryoris and others added 2 commits December 20, 2021 19:02
Copy link
Copy Markdown
Member

@mrossinek mrossinek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some minor comments.

Comment thread qiskit_nature/problems/second_quantization/lattice/lattices/lattice.py Outdated
Comment thread releasenotes/notes/lattice-edge-typecheck-3f5b4896fe26c8dc.yaml Outdated
@coveralls
Copy link
Copy Markdown

coveralls commented Dec 21, 2021

Pull Request Test Coverage Report for Build 1755903744

  • 6 of 7 (85.71%) changed or added relevant lines in 1 file are covered.
  • 3 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.005%) to 85.361%

Changes Missing Coverage Covered Lines Changed/Added Lines %
qiskit_nature/problems/second_quantization/lattice/lattices/lattice.py 6 7 85.71%
Files with Coverage Reduction New Missed Lines %
qiskit_nature/drivers/psi4d/psi4driver.py 1 87.18%
qiskit_nature/drivers/second_quantization/psi4d/psi4driver.py 2 86.47%
Totals Coverage Status
Change from base Build 1752310712: -0.005%
Covered Lines: 10111
Relevant Lines: 11845

💛 - Coveralls

mrossinek
mrossinek previously approved these changes Dec 21, 2021
Copy link
Copy Markdown
Member

@mrossinek mrossinek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks @Cryoris!
We'll probably hold off the merge until one other dev has the chance to review this but most of us are already on vacaiton.

Comment thread .pylintdict Outdated
Copy link
Copy Markdown
Member

@mrossinek mrossinek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@mrossinek mrossinek requested a review from dlasecki January 11, 2022 07:46
mrossinek added a commit to mrossinek/qiskit-nature that referenced this pull request Jan 27, 2022
…unity#471)

* edge typecheck in lattice input

Co-authored-by: Matthew Treinish <mtreinish@kortar.org>

* spell & rm unwanted change

* alphabetical order in pylintdict

Co-authored-by: Matthew Treinish <mtreinish@kortar.org>
Co-authored-by: Manoel Marques <Manoel.Marques@ibm.com>
Co-authored-by: Max Rossmannek <oss@zurich.ibm.com>
Co-authored-by: dlasecki <dal@zurich.ibm.com>
Co-authored-by: Panagiotis Barkoutsos <bpa@zurich.ibm.com>
@mrossinek
Copy link
Copy Markdown
Member

Something appears to have gone wrong with mergify here. The PR is merged properly into main (see aa910c9) so I am closing this manually.

@mrossinek mrossinek closed this Jan 27, 2022
manoelmarques added a commit to manoelmarques/qiskit-nature that referenced this pull request Jan 27, 2022
…unity#471)

* edge typecheck in lattice input

Co-authored-by: Matthew Treinish <mtreinish@kortar.org>

* spell & rm unwanted change

* alphabetical order in pylintdict

Co-authored-by: Matthew Treinish <mtreinish@kortar.org>
Co-authored-by: Manoel Marques <Manoel.Marques@ibm.com>
Co-authored-by: Max Rossmannek <oss@zurich.ibm.com>
Co-authored-by: dlasecki <dal@zurich.ibm.com>
Co-authored-by: Panagiotis Barkoutsos <bpa@zurich.ibm.com>
manoelmarques added a commit that referenced this pull request Jan 27, 2022
…opyright after cross-year merge (#523)

* Typechecking edge weights of input graphs to ``Lattice`` (#471)

* edge typecheck in lattice input

Co-authored-by: Matthew Treinish <mtreinish@kortar.org>

* spell & rm unwanted change

* alphabetical order in pylintdict

Co-authored-by: Matthew Treinish <mtreinish@kortar.org>
Co-authored-by: Manoel Marques <Manoel.Marques@ibm.com>
Co-authored-by: Max Rossmannek <oss@zurich.ibm.com>
Co-authored-by: dlasecki <dal@zurich.ibm.com>
Co-authored-by: Panagiotis Barkoutsos <bpa@zurich.ibm.com>

* Fix copyright after cross-year merge (#522)

* Fix copyright after cross-year merge

* pylint: disable useless-suppression again

Partially reverts a8a5d9b.
The reasson for disabling again is that this will cause different
warnings across different python-versions. While this does not fail the
CI (which is why it first went unnoticed) it litters its output with
warnings unnecessarily.

Co-authored-by: Julien Gacon <gaconju@gmail.com>
Co-authored-by: Matthew Treinish <mtreinish@kortar.org>
Co-authored-by: Max Rossmannek <oss@zurich.ibm.com>
Co-authored-by: dlasecki <dal@zurich.ibm.com>
Co-authored-by: Panagiotis Barkoutsos <bpa@zurich.ibm.com>
@Cryoris Cryoris deleted the lattice-edge-typecheck branch January 28, 2022 07:19
Anthony-Gandon pushed a commit to Anthony-Gandon/qiskit-nature that referenced this pull request May 25, 2023
…unity#471)

* edge typecheck in lattice input

Co-authored-by: Matthew Treinish <mtreinish@kortar.org>

* spell & rm unwanted change

* alphabetical order in pylintdict

Co-authored-by: Matthew Treinish <mtreinish@kortar.org>
Co-authored-by: Manoel Marques <Manoel.Marques@ibm.com>
Co-authored-by: Max Rossmannek <oss@zurich.ibm.com>
Co-authored-by: dlasecki <dal@zurich.ibm.com>
Co-authored-by: Panagiotis Barkoutsos <bpa@zurich.ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Type check edge weights in Lattice constructions?

6 participants