Skip to content

Bind parameters of SparseLabelOp recursively #1008

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mrossinek merged 3 commits into from
Dec 19, 2022
Merged

Bind parameters of SparseLabelOp recursively #1008

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8e64ffe
bind parameters recursively
kevinsung Dec 19, 2022
1af5fe1
use slower workaround that works with current Terra version
kevinsung Dec 19, 2022
e1fabc6
add release note
kevinsung Dec 19, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion qiskit_nature/second_q/operators/sparse_label_op.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -511,7 +511,13 @@ def assign_parameters(self, parameters: Mapping[ParameterExpression, _TCoeff]) -
A new operator with the parameters assigned.
"""
data = {
key: parameters[value] if value in parameters else value
# TODO use this line once
# https://github.com/Qiskit/qiskit-terra/pull/9304
# is merged:
# key: value.bind(parameters, allow_unknown_parameters=True)
key: value.bind({k: v for k, v in parameters.items() if k in value.parameters})
if isinstance(value, ParameterExpression)
else value
for key, value in self._data.items()
}
return self._new_instance(data, other=self)
Expand Down
5 changes: 5 additions & 0 deletions releasenotes/notes/fix-bind-params-a2851b14e3b8e247.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
fixes:
- |
Fixes :meth:`.SparseLabelOp.assign_parameters` failing to
assign parameters recursively.
8 changes: 8 additions & 0 deletions test/second_q/operators/test_sparse_label_op.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -418,6 +418,14 @@ def test_assign_parameters(self):
self.assertEqual(assigned_op, DummySparseLabelOp({"+_0 -_1": 1.0, "+_0 -_2": b}))
self.assertEqual(op, DummySparseLabelOp({"+_0 -_1": a, "+_0 -_2": b}))

op = DummySparseLabelOp({"+_0 -_1": a + 1}) + DummySparseLabelOp({"+_1 -_0": a})
assigned_op = op.assign_parameters({a: 1})
self.assertEqual(assigned_op, DummySparseLabelOp({"+_0 -_1": 2, "+_1 -_0": 1}))

op = DummySparseLabelOp({"+_0 -_1": a + 1}) + DummySparseLabelOp({"+_1 -_0": b})
assigned_op = op.assign_parameters({a: 1})
self.assertEqual(assigned_op, DummySparseLabelOp({"+_0 -_1": 2, "+_1 -_0": b}))

def test_round(self):
"""test round function"""
with self.subTest("round just real part"):
Expand Down