Skip to content

Bind parameters of SparseLabelOp recursively#1008

Merged
mrossinek merged 3 commits into
qiskit-community:mainfrom
kevinsung:bind-params
Dec 19, 2022
Merged

Bind parameters of SparseLabelOp recursively#1008
mrossinek merged 3 commits into
qiskit-community:mainfrom
kevinsung:bind-params

Conversation

@kevinsung
Copy link
Copy Markdown
Contributor

@kevinsung kevinsung commented Dec 19, 2022 •
edited
Loading

Summary

Fixes #1006.

Details and comments

mrossinek
mrossinek reviewed Dec 19, 2022
View reviewed changes
Comment thread qiskit_nature/second_q/operators/sparse_label_op.py Outdated
mrossinek
mrossinek reviewed Dec 19, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@mrossinek mrossinek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And please also add a release note

Comment thread test/second_q/operators/test_sparse_label_op.py Outdated
@mrossinek mrossinek added the stable backport potential The bug might be minimal and/or import enough to be port to stable label Dec 19, 2022
@kevinsung kevinsung mentioned this pull request Dec 19, 2022
Closed
@mrossinek mrossinek self-requested a review December 19, 2022 12:30
@coveralls
Copy link
Copy Markdown

coveralls commented Dec 19, 2022

Pull Request Test Coverage Report for Build 3731339582

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.0%) to 85.917%
Totals Coverage Status
Change from base Build 3677752262: -0.0%
Covered Lines: 17418
Relevant Lines: 20273
💛 - Coveralls

mrossinek
mrossinek approved these changes Dec 19, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@mrossinek mrossinek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Kevin 👍

@mrossinek mrossinek merged commit d81d72b into qiskit-community:main Dec 19, 2022
@mergify mergify Bot mentioned this pull request Dec 19, 2022
Merged
mergify Bot pushed a commit that referenced this pull request Dec 19, 2022
@kevinsung @mergify
Bind parameters of SparseLabelOp recursively (#1008)
de6d35b 
* bind parameters recursively

* use slower workaround that works with current Terra version

* add release note

(cherry picked from commit d81d72b)
@kevinsung kevinsung deleted the bind-params branch December 19, 2022 13:42
mergify Bot added a commit that referenced this pull request Dec 19, 2022
@mergify @kevinsung
Bind parameters of SparseLabelOp recursively (#1008) (#1011)
2d83442 
* bind parameters recursively

* use slower workaround that works with current Terra version

* add release note

(cherry picked from commit d81d72b)

Co-authored-by: Kevin J. Sung <kevjsung@umich.edu>
@kevinsung kevinsung mentioned this pull request Jan 16, 2023
Merged
Anthony-Gandon pushed a commit to Anthony-Gandon/qiskit-nature that referenced this pull request May 25, 2023
@kevinsung
Bind parameters of SparseLabelOp recursively (qiskit-community#1008)
1c6fc7a 
* bind parameters recursively

* use slower workaround that works with current Terra version

* add release note
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mrossinek mrossinek mrossinek approved these changes

@stefan-woerner stefan-woerner Awaiting requested review from stefan-woerner

@manoelmarques manoelmarques Awaiting requested review from manoelmarques

@woodsp-ibm woodsp-ibm Awaiting requested review from woodsp-ibm woodsp-ibm is a code owner

Assignees

No one assigned

Labels

stable backport potential The bug might be minimal and/or import enough to be port to stable

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

SparseLabelOp fails to assign parameters recursively

3 participants

@kevinsung @coveralls @mrossinek