[WIP] Spectroscopy and calibrations integration V1#80
Closed
eggerdj wants to merge 2 commits into
Closed
Conversation
This was referenced Jun 4, 2021
Collaborator
|
If we go on a dedicated function, then there are three options:
All these three options share the same pros and cons as written above. There is an additional con (also shared by all of them): although the user enjoys the benefit of not writing a lot of code, she will also suffer from the large number of different functions. She will have to understand which functions exist, what exactly they do, how to use them, what are the differences between them. So a large number of functions to maintain can be a headache not only to developers, but also to users. |
Contributor
Author
|
Closed by #88 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This is a WIP PR to show and discuss how spectroscopy and calibrations can be integrated through the
BackendCalibrationsclass. See an alternative here: #79.Details and comments
The spectroscopy experiment is integrated with the calibrations through the
BackendCalibrationsclass. The user will execute the following code:The pros of this integration are:
The cons of this integrations are:
BackendCalibrationswill contain a function for each calibration experiment that we will support and may become large.