[WIP] Spectroscopy and calibrations integration V2#79
Closed
eggerdj wants to merge 1 commit into
Closed
Conversation
This was referenced Jun 4, 2021
Collaborator
|
When you compare the number of lines that the user has to write in #79 and #80, note that there is something "unfair" for #79: #79 contains two lines for calculating By the way, In both #79 and #80, if we want to calculate the frequencies from the calibrations, we can do it internally for the user. |
Contributor
Author
|
Closed by #88 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This is a WIP PR designed to show and discuss how calibrations and experiments could be integrated through the analysis class. An alternative option is shown in #80.
Details and comments
The user would run the calibration experiment as follows:
The pros of this integration are:
BackendCalibrationsclass will remain lightweight.The cons of this integration are: