This repository was archived by the owner on Dec 7, 2021. It is now read-only.
Improve handling of params argument in Gradient.convert#1493
Closed
alpha-magic wants to merge 2 commits intoqiskit-community:masterfrom
Closed
Improve handling of params argument in Gradient.convert#1493alpha-magic wants to merge 2 commits intoqiskit-community:masterfrom
params argument in Gradient.convert#1493alpha-magic wants to merge 2 commits intoqiskit-community:masterfrom
Conversation
…anBased subclasses 2) fix on handling `params` of type ParameterExpression
alpha-magic
requested review from
levbishop,
manoelmarques and
woodsp-ibm
as code owners
Member
|
@Cryoris Is this PR valid/required any more since opflow has been moved to Terra repo and this has been done there by Qiskit/qiskit#5548. While the change can be done here too since it says 'improve' maybe this PR is best just closed since I see other discussion/changes done in the Terra PR. |
Contributor
Author
|
@woodsp-ibm OK let me close this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves https://github.com/Qiskit/qiskit-aqua/issues/1466
Summary
paramsare required in convert method in GradientBased and HessianBased subclassesparamsof type ParameterExpression