Improved handling of params argument in Gradient.convert#5548
Merged
mergify[bot] merged 13 commits intoQiskit:masterfrom Jan 13, 2021
Merged
Improved handling of params argument in Gradient.convert#5548mergify[bot] merged 13 commits intoQiskit:masterfrom
params argument in Gradient.convert#5548mergify[bot] merged 13 commits intoQiskit:masterfrom
Conversation
alpha-magic
requested review from
a team,
manoelmarques and
woodsp-ibm
as code owners
Cryoris
reviewed
Dec 23, 2020
Collaborator
Cryoris
left a comment
Cryoris
left a comment
There was a problem hiding this comment.
Looks good, thanks for the addition! Could you add a test that checks that all methods allow a ParameterVector? That could be just something really simple with a length-1 parameter vector 🙂
…Based subclasses 2. fix on handling params of type ParameterExpression
Co-authored-by: Julien Gacon <gaconju@gmail.com>
* passmanager callback removal * unused-import * reno
Co-authored-by: Kevin Krsulich <kevin.krsulich@ibm.com>
…turalGradient, QFI and Hessian 2) index method added to ParameterVector 3) handling of ParameterVector changed for Hessian to be consistent with list params
alpha-magic
force-pushed
the
issue_1466
branch
from
36ec7b6 to
1f504ab
Compare
Contributor
Author
|
Thanks for the review @Cryoris. I modified few existing tests, all gradient modules are tested also with I did minor change in handling the |
Cryoris
requested changes
Dec 28, 2020
Collaborator
Cryoris
left a comment
Cryoris
left a comment
There was a problem hiding this comment.
One thing we should address but otherwise LGTM 🙂
alpha-magic
force-pushed
the
issue_1466
branch
from
4f4889f to
3509ae4
Compare
…modified accordingly
alpha-magic
force-pushed
the
issue_1466
branch
from
3509ae4 to
6b4e4bd
Compare
* general polynomial approximation * release notes * fix qubit re-allocation * fix re-calling build * Update qiskit/circuit/library/arithmetic/piecewise_chebyshev.py Co-authored-by: Julien Gacon <gaconju@gmail.com> * Update qiskit/circuit/library/arithmetic/piecewise_chebyshev.py Co-authored-by: Julien Gacon <gaconju@gmail.com> * Update qiskit/circuit/library/arithmetic/piecewise_chebyshev.py Co-authored-by: Julien Gacon <gaconju@gmail.com> * fix indentation lint error * move tests to library module * Add suggestions from code review Co-authored-by: Julien Gacon <gaconju@gmail.com>
As reported on multiple occasions in Qiskit Aqua ([1], [2]), the eigenvalues of the auxiliary operators are not correctly normalized when the QASM backend is used. This commit fixes this short-coming by applying the same normalization to the VQE's eigenstate when obtained from a QASM backend (in which case this is a dictionary) as done by the `CircuitSampler` in its `sample_circuits` function. The case of the statevector backend is unaffected by this change, as it will return the eigenstate as a list. A unittest is added which asserts this behavior. [1]: https://github.com/Qiskit/qiskit-aqua/issues/1460 [2]: qiskit-community/qiskit-aqua#1467 Co-authored-by: Julien Gacon <gaconju@gmail.com> Co-authored-by: Julien Gacon <gaconju@gmail.com> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
…odified accordingly
Cryoris
approved these changes
Jan 13, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves https://github.com/Qiskit/qiskit-aqua/issues/1466, resolves #5553
Summary