vis-network-9.0.4 #3092
Closed
vis-network-9.0.4 #3092
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ElDeveloper
suggested changes
Apr 13, 2021
| False]) | ||
| try: | ||
| at_id = qdb.util.convert_to_id(at, 'artifact_type') | ||
| except qdb.exceptions.QiitaDBLookupError: |
There was a problem hiding this comment.
Can you add a unit test for this exception?
|
After finding the latest open issue reported here: #2968; I don't think it's worth updating to the latests version of vis-network. Thus, closing this PR and opening a new one with the code modifications and the requested test. |
antgonza
added a commit
to antgonza/qiita
that referenced
this pull request
Apr 16, 2021
Merged
ElDeveloper
pushed a commit
that referenced
this pull request
Apr 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating vis-network to latests version 9.0.4 and a minor error reporting modification that was helpful while creating https://github.com/qiita-spots/qp-spades