Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Processing network - change refresh to not alter network topology #2968

Closed
justinshaffer opened this issue Jan 12, 2020 · 14 comments
Closed

Comments

@justinshaffer
Copy link
Contributor

Hello,

It would be helpful if the topology of the processing network was maintained following refreshing. For large networks, it can be confusing when going through results, that the network topology is often reshuffled following refreshing. One option is to maintain the same topology during refresh. A second option would be to allow the user the option to 'turn off' refreshing, particularly when no processing is occurring and the user is merely going through what was ran or outputs.

Thanks in advance,

Justin

@antgonza
Copy link
Member

Agree this is super annoying so I spent sometime trying to figure it out. Turns out that this is an issue with the library (https://github.com/visjs/vis-network/releases) we use, see links below. In this process, I realized that we haven't updated this library in a really long time; thus, created #2969.

almende/vis#1927
almende/vis#215
almende/vis#2017
almende/vis#787
https://ww3.arb.ca.gov/ei/tools/lib/vis/docs/dataset.html
https://visjs.github.io/vis-network/docs/network/layout.html

@antgonza
Copy link
Member

This has been fixed in the last deploy and confirmed (in qiita-rc) by @justinshaffer and @tkosciol.

@antgonza
Copy link
Member

Reopening as in the main site the randomization of branches is still happening.

@antgonza
Copy link
Member

I have been trying to solve this and found this issue: visjs/vis-network#926; looks like we need to find another library for this.

@antgonza
Copy link
Member

@tkosciol
Copy link

Some "good" options to explore:

  1. https://github.com/antvis/G6/
  2. https://github.com/jsplumb/jsplumb/
  3. https://github.com/cytoscape/cytoscape.js

all look really good! I wonder if there is an option from those 3 that would require least adaptation of the codebase?

@antgonza
Copy link
Member

I'm investigating - checked those 3 and they are hard to adapt, currently checking https://observablehq.com/@d3/gallery

@antgonza
Copy link
Member

OK, did an "in-depth" review of this and some good reads are:

Took the best candidates and created a branch modifying the workflow page as it's an easy test. The summary of these tests is:

@justinshaffer
Copy link
Contributor Author

justinshaffer commented Apr 23, 2021 via email

@antgonza
Copy link
Member

Fixed on 2021.05.

@roininja
Copy link

roininja commented Jun 8, 2024

Hi @antgonza,
Apologies if I could not understand (through above comments) but wanted to know if issue visjs/vis-network#926 is resolved since I can't get the nodes sorting in correct order even if I use current version 9.1.9.

@antgonza
Copy link
Member

Hi @roininja; our solution was to replace visjs with cytoscape.js. Best,

@roininja
Copy link

Hi @roininja; our solution was to replace Vis JS with cytoscape.js. Best,

Thanks @antgonza. Just to clarify, did you mean to say Cytoscape's logic (sorting node order in hierarchical Layout) is included in Vis JS OR if someone wants to use that functionality, then, s/he should switch over to Cytoscape instead of Vis JS?

Many Thanks.

@antgonza
Copy link
Member

I meant the latter; switch to cytoscape.js. However, note that we did this around 3 years ago because vis.js didn't have that functionality + it allowed us to extend some other features; however, things might have changed now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants