Fix #4482: Update Month Picker and Year Picker to select dates also on press of "SPACE" key #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adjust Month picker and Year picker to align with W3C WAI-ARIA principles. Previously, the date gets selected only on "Enter" key press. After this change, [both "Enter" and "Space" can select a date from both Month picker and Year picker](https://www.w3.org/WAI/ARIA/apg/patterns/dialog-modal/examples/datepicker-dialog/)
balajis-qb
changed the title
balajis-qb
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes Hacker0x01#4482
Description
This PR addresses the date selection behavior in the calendar component to enhance accessibility based on W3C WAI-ARIA principles. Previously, the "Enter" key alone is used to select a Month picker and a Year Picker. But As per W3C WAI-ARIA principle both the "Enter" & "Space" keys should be able to select a date. Currently, only the date selector is selecting a date on both the "Enter" and the "Space" key. Hence I updated the Year Picker and the Month Picker to work like the date picker to select a date both by "Space" and "Enter" keys click.
Reference Link
Changes Made