Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Month in Month Picker and Year in Year Picker cannot be selected by pressing the "Space" on keyboard. #4482

Closed
BoriskinaAnna opened this issue Jan 30, 2024 · 0 comments · Fixed by qburst/react-datepicker-3#13 or #4512
Closed

Month in Month Picker and Year in Year Picker cannot be selected by pressing the "Space" on keyboard. #4482

BoriskinaAnna opened this issue Jan 30, 2024 · 0 comments · Fixed by qburst/react-datepicker-3#13 or #4512

Comments

@BoriskinaAnna
Copy link

BoriskinaAnna commented Jan 30, 2024 •
edited
Loading

Describe the bug
Month in Month Picker and Year in Year Picker cannot be selected by pressing the "Space" on keyboard. Only "Enter" works.

To Reproduce

  1. Navigate through the Month or Year Picker using keyboard.
  2. Try to select any new value using "Space".

Expected behavior
New value is selected according to the https://www.w3.org/WAI/ARIA/apg/patterns/dialog-modal/examples/datepicker-dialog/

Desktop (please complete the following information):

  • OS: Windows 11
  • Browser Chrome
  • Version 120.0.6099.225
This was referenced Feb 12, 2024
Merged
Merged
balajis-qb pushed a commit to qburst/react-datepicker-3 that referenced this issue Feb 13, 2024
refactor: ♻️ Move the isSpaceKeyDown check to a helper function for r…
7e82975 
…euse

Closes Hacker0x01#4482
martijnrusschen added a commit that referenced this issue Feb 13, 2024
@martijnrusschen
Merge pull request #4512 from qburst/issue-4482/fix/enable-space-clic…
833bb68 
…k-on-year-and-month-picker

Fix #4482: Update Month Picker and Year Picker to select dates also on press of "SPACE" key
@balajis-qb balajis-qb mentioned this issue Feb 25, 2024
Closed
@IrvingYHM IrvingYHM mentioned this issue Jun 2, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@BoriskinaAnna