Skip to content

Support libtorrent v2.0.4 in CI#15340

Merged
Chocobo1 merged 4 commits into
qbittorrent:masterfrom
Chocobo1:libt2
Aug 19, 2021
Merged

Support libtorrent v2.0.4 in CI#15340
Chocobo1 merged 4 commits into
qbittorrent:masterfrom
Chocobo1:libt2

Conversation

@Chocobo1
Copy link
Copy Markdown
Member

@Chocobo1 Chocobo1 commented Aug 18, 2021

  • Support libtorrent v2.0.4 in CI
  • Remove OS variable from build matrix
    It is meaningless to build on multiple linux versions as we only depend on library versions, not OS versions.
    Also remove redundant "shell default" section.
  • Move global environment variables out
  • Use ccache in CI

@Chocobo1 Chocobo1 added the CI Issues/PRs related to CI label Aug 18, 2021
@glassez
Copy link
Copy Markdown
Member

glassez commented Aug 18, 2021

@Chocobo1
All these commits affect CI but not all of them mention this fact. Please fix commit messages. I would suggest to use CI: prefix (or even GHA CI:).

@Chocobo1 Chocobo1 force-pushed the libt2 branch 2 times, most recently from 64b2bf9 to cc9cb8c Compare August 18, 2021 14:58
It is meaningless to build on multiple linux versions as we only depend
on library versions, not OS versions.
Also remove redundant "shell default" section.
@Chocobo1
Copy link
Copy Markdown
Member Author

All these commits affect CI but not all of them mention this fact. Please fix commit messages. I would suggest to use CI: prefix (or even GHA CI:).

Done.

@Chocobo1 Chocobo1 merged commit d0d0bed into qbittorrent:master Aug 19, 2021
@Chocobo1 Chocobo1 deleted the libt2 branch August 19, 2021 02:54
Chocobo1 added a commit to Chocobo1/qBittorrent that referenced this pull request Aug 22, 2021
By having unified github workflows, the building cache would be utilized
more efficiently as the total cache size will be smaller (no more vcpkg
caching on macOS CI) and will stop thrashing the build cache (large
vcpkg cache evicts other smaller cache).

Relevant PRs:
qbittorrent#15321
qbittorrent#15340
qbittorrent#15342
qbittorrent#15355
Chocobo1 added a commit that referenced this pull request Aug 23, 2021
By having unified github workflows, the building cache would be utilized
more efficiently as the total cache size will be smaller (no more vcpkg
caching on macOS CI) and will stop thrashing the build cache (large
vcpkg cache evicts other smaller cache).

Relevant PRs:
#15321
#15340
#15342
#15355
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI Issues/PRs related to CI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants