Skip to content

Add new Ubuntu build jobs to CI#15090

Closed
FranciscoPombal wants to merge 1 commit into
qbittorrent:masterfrom
FranciscoPombal:update_ci
Closed

Add new Ubuntu build jobs to CI#15090
FranciscoPombal wants to merge 1 commit into
qbittorrent:masterfrom
FranciscoPombal:update_ci

Conversation

@FranciscoPombal
Copy link
Copy Markdown
Member

@FranciscoPombal FranciscoPombal commented Jun 11, 2021

Raise minimum libtorrent version to 1.2.14 (2.0.4)

- Also update vcpkg to latest commit: includes libtorrent 1.2.14,
Qt 5.15.2, and Qt 6.1.0

Commit split to #15093.


GitHub Actions CI: update workflow

  • Add more Ubuntu jobs with libtorrent RC_1_2 branch HEAD, latest RC_2_0
    tag and RC_2_0 branch HEAD.

libtorrent 1.2.x was just updated to 1.2.14 on vcpkg, so we can bump the version.
New jobs were added to the GitHub Actions CI to bring it up to par with Travis, which I just noticed has RC_2_0 jobs.

Similar jobs for Windows and macOS will be added later once I get libtorrent 2.0 into vcpkg.

Meanwhile, this latest vcpkg commit also includes Qt6, so we will be ready for the switch. @glassez Once this PR is merged, you should rebase your experimental qt6 branch on top of master to ease experimentation.

@FranciscoPombal FranciscoPombal added Build system Issue with the build configuration or scripts (but not the code itself) CI Issues/PRs related to CI labels Jun 11, 2021
@FranciscoPombal FranciscoPombal force-pushed the update_ci branch 6 times, most recently from 6c13e4e to 4d42dbb Compare June 11, 2021 17:03
@FranciscoPombal
Copy link
Copy Markdown
Member Author

new CI is working correctly now.

Copy link
Copy Markdown
Member

@glassez glassez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@FranciscoPombal
Please put commits into separate PRs.

@FranciscoPombal FranciscoPombal changed the title Raise minimum libtorrent version to 1.2.14 (2.0.4) and add new Ubuntu build jobs to CI Add new Ubuntu build jobs to CI Jun 12, 2021
@FranciscoPombal
Copy link
Copy Markdown
Member Author

@glassez

Well, I thought these 2 commits would be good candidates for the same PR. In any case, the one bumping libtorrent was split into #15093. They are technically independent, so they can be merged in any order, but it would make a bit more sense to merge #15093 first IMO.

@FranciscoPombal FranciscoPombal requested a review from glassez June 12, 2021 09:13
@glassez
Copy link
Copy Markdown
Member

glassez commented Jun 12, 2021

@FranciscoPombal
Why do we really need both latest release and latest commit builds for each libtorrent branch?

@FranciscoPombal
Copy link
Copy Markdown
Member Author

@glassez

@FranciscoPombal
Why do we really need both latest release and latest commit builds for each libtorrent branch?

Why not? It costs us nothing and is more defensive. If we do anything that triggers some warning/deprecation/error in the latest commits of libtorrent, we'll know about it even before we bump the minimum required tagged version.

@FranciscoPombal
Copy link
Copy Markdown
Member Author

Windows CI failure looks spurious.

glassez
glassez previously approved these changes Jun 13, 2021
Comment thread .github/workflows/ci.yaml
@sledgehammer999
Copy link
Copy Markdown
Member

FYI, I have a PPA recipes that daily imports and builds RC_1_2.
I don't know if adding the PPA will produce faster CI builds. You could check that if you want. This is just an info comment.

PPA: https://launchpad.net/~qbittorrent-team/+archive/ubuntu/qbt-libtorrent-travisci

PS: Unfortunately I can't do the same for RC_2_0 because it uses git submodules and launchpad doesn't import that correctly.

- Add more Ubuntu jobs with libtorrent RC_1_2 branch HEAD, latest RC_2_0
tag and RC_2_0 branch HEAD.
@FranciscoPombal
Copy link
Copy Markdown
Member Author

@glassez @sledgehammer999

FYI, I have a PPA recipes that daily imports and builds RC_1_2.
I don't know if adding the PPA will produce faster CI builds. You could check that if you want. This is just an info comment.

PPA: https://launchpad.net/~qbittorrent-team/+archive/ubuntu/qbt-libtorrent-travisci

PS: Unfortunately I can't do the same for RC_2_0 because it uses git submodules and launchpad doesn't import that correctly.

Thanks, but I think that at least for now, this is the simplest and most flexible way - it is simple to setup both RC_1_2 and RC_2_0 builds.

Since #15093 is merged, this is now ready as well.

@FranciscoPombal
Copy link
Copy Markdown
Member Author

@sledgehammer999 @Chocobo1

Any further comments? This is ready.

@FranciscoPombal
Copy link
Copy Markdown
Member Author

@Chocobo1 @glassez ping.

@FranciscoPombal
Copy link
Copy Markdown
Member Author

@sledgehammer999 @glassez @Chocobo1 ping.

@xavier2k6
Copy link
Copy Markdown
Member

Superseded by #15340

@xavier2k6 xavier2k6 closed this Aug 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Build system Issue with the build configuration or scripts (but not the code itself) CI Issues/PRs related to CI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants