Merge pull request #5 from qahive/support-robotframework-puppeteer-v2

Support robotframework puppeteer v2
qahive · Feb 12, 2021 · cc97651 · cc97651
2 parents 4da0ab2 + 9a85ff3
commit cc97651
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 4 deletions.
diff --git a/.gitignore b/.gitignore
@@ -251,3 +251,5 @@ report.html
 Examples/red.xml
 Examples/.project
 Examples/.gitignore
+Examples/puppeteer-screenshot-1.png
+Examples/selenium-screenshot-1.png
diff --git a/Examples/quick-start.robot b/Examples/quick-start.robot
@@ -10,13 +10,11 @@ Capture http page screenshot
     ${HEADLESS}     Get variable value    ${HEADLESS}    ${False}
     &{options} =    create dictionary   headless=${HEADLESS}
     Open browser    http://example.com  options=${options}
-    Maximize Browser Window
     Percy Snapshot    HTTP page
 
 Capture https page screenshot
     ${HEADLESS}     Get variable value    ${HEADLESS}    ${False}
     &{options} =    create dictionary   headless=${HEADLESS}
     Open browser    https://www.w3schools.com/  options=${options}
-    Maximize Browser Window
     Percy Snapshot    HTTPs page
 
diff --git a/PuppeteerPercy/__init__.py b/PuppeteerPercy/__init__.py
@@ -3,7 +3,7 @@
 from robot.api.deco import keyword, not_keyword
 from robot.libraries.BuiltIn import BuiltIn
 
-__version__ = '0.1.0'
+__version__ = '0.1.1'
 
 
 class PuppeteerPercy:
@@ -27,7 +27,7 @@ def percy_snapshot(self, name, **kwargs):
     @not_keyword
     async def percy_snapshot_async(self, name, **kwargs):
         puppeteerLibrary = BuiltIn().get_library_instance('PuppeteerLibrary')
-        page = puppeteerLibrary.get_current_page()
+        page = puppeteerLibrary.get_current_library_context().get_current_page()
 
         # Exit if we have failed to connect to the percy-agent server
         if self.percyIsRunning == False:

diff --git a/README.md b/README.md
@@ -6,6 +6,7 @@ Keyword documentation
 ---------------------
 See [`keyword documentation`](https://qahive.github.io/robotframework-puppeteer-percy/PuppeteerPercy.html) for available keywords and more information about the library in general.
 
+Require [robotframework-puppeteer]](https://github.com/qahive/robotframework-puppeteer) version 2 or above.
 
 Installation
 ------------
-Original file line number
+Diff line change
@@ Expand Up / @@ -6,6 +6,7 @@ Keyword documentation @@
     ---------------------
     See [`keyword documentation`](https://qahive.github.io/robotframework-puppeteer-percy/PuppeteerPercy.html) for available keywords and more information about the library in general.
+    Require [robotframework-puppeteer]](https://github.com/qahive/robotframework-puppeteer) version 2 or above.
     Installation
     ------------
@@ Expand Down @@