encapsulate snapshot restoration params in a struct #598
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Few imports of torchsnapshot were outside of the try catch that checks if torchsnapshot is in the environment. This diff moves them into the try catch block Reviewed By: galrotem Differential Revision: D50754606
Summary: # Context Users may want to opt out of restoring certain parts of the app state (for example, like optimizer and lr scheduler states when finetuning). This is currently not supported in torchsnapshot saver # This Diff * Adds `RestoreOptions` dataclass to encapsulate all restoration params * moves `restore_train_progress`, `restore_eval_progress` to the struct * Replaces all `restore` apis to take `RestoreOptions` struct, replacing the `restore_train_progress`, `restore_eval_progress` * Adds optimizer and lr_scheduler to `RestoreOptions` Differential Revision: D50757494
|
This pull request was exported from Phabricator. Differential Revision: D50757494 |
Codecov Report
@@ Coverage Diff @@
## master #598 +/- ##
==========================================
+ Coverage 86.95% 86.99% +0.04%
==========================================
Files 66 66
Lines 4131 4144 +13
==========================================
+ Hits 3592 3605 +13
Misses 539 539
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Context
Users may want to opt out of restoring certain parts of the app state (for example, like optimizer and lr scheduler states when finetuning). This is currently not supported in torchsnapshot saver
This Diff
RestoreOptionsdataclass to encapsulate all restoration paramsrestore_train_progress,restore_eval_progressto the structrestoreapis to takeRestoreOptionsstruct, replacing therestore_train_progress,restore_eval_progressRestoreOptionsDifferential Revision: D50757494