move snapshot imports into try catch #597
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Few imports of torchsnapshot were outside of the try catch that checks if torchsnapshot is in the environment. This diff moves them into the try catch block Differential Revision: D50754606
|
This pull request was exported from Phabricator. Differential Revision: D50754606 |
Codecov Report
@@ Coverage Diff @@
## master #597 +/- ##
=======================================
Coverage 86.95% 86.95%
=======================================
Files 66 66
Lines 4131 4131
=======================================
Hits 3592 3592
Misses 539 539
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
JKSenthil
added a commit
to JKSenthil/tnt
that referenced
this pull request
Oct 27, 2023
Summary: Few imports of torchsnapshot were outside of the try catch that checks if torchsnapshot is in the environment. This diff moves them into the try catch block Reviewed By: galrotem Differential Revision: D50754606
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Few imports of torchsnapshot were outside of the try catch that checks if torchsnapshot is in the environment. This diff moves them into the try catch block
Differential Revision: D50754606