Always check for x86-ish with the same regex.#93
Merged
malfet merged 1 commit intopytorch:masterfrom Jul 5, 2022
BillyONeal:consistent-intel-ish
Merged
Always check for x86-ish with the same regex.#93malfet merged 1 commit intopytorch:masterfrom BillyONeal:consistent-intel-ish
malfet merged 1 commit intopytorch:masterfrom
BillyONeal:consistent-intel-ish
Conversation
On line 68, and in most places, "intel-like" is checked with `i[3-6]86|AMD64|x86(_64)?`, but in these 3 places the (_x64)? was missing. First reported as microsoft/vcpkg#24713
BillyONeal
added a commit
to BillyONeal/vcpkg
that referenced
this pull request
Jun 15, 2022
Submitted upstream as pytorch/cpuinfo#93 Resolves microsoft#24713 Competing resolution of microsoft#24726
BillyONeal
added a commit
to microsoft/vcpkg
that referenced
this pull request
Jun 16, 2022
Submitted upstream as pytorch/cpuinfo#93 Resolves #24713 Competing resolution of #24726
malfet
approved these changes
Jul 5, 2022
megengine-bot
pushed a commit
to MegEngine/cpuinfo
that referenced
this pull request
Sep 5, 2022
On line 68, and in most places, "intel-like" is checked with `i[3-6]86|AMD64|x86(_64)?`, but in these 3 places the (_x64)? was missing. First reported as microsoft/vcpkg#24713 GitOrigin-RevId: 44d0af8
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On line 68, and in most places, "intel-like" is checked with
i[3-6]86|AMD64|x86(_64)?, but in these 3 places the (_x64)? was missing.First reported as microsoft/vcpkg#24713