[cpuinfo] Always check for x86-ish with the same regex.#25258
Merged
BillyONeal merged 1 commit intomicrosoft:masterfrom Jun 16, 2022
Merged
[cpuinfo] Always check for x86-ish with the same regex.#25258BillyONeal merged 1 commit intomicrosoft:masterfrom
BillyONeal merged 1 commit intomicrosoft:masterfrom
Conversation
Submitted upstream as pytorch/cpuinfo#93 Resolves microsoft#24713 Competing resolution of microsoft#24726
BillyONeal
added
category:port-bug
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Cheney-W
added
the
info:needs-maintainer-attention
Contributor
|
Your PR is indeed more correct than mine, I didn't realize it was a regex bug. |
Member
Author
|
Thanks for the review @Cheney-W ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Submitted upstream as pytorch/cpuinfo#93
Resolves #24713
Competing resolution of #24726