Mathjax support #20
Closed
Mathjax support #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
There was a problem hiding this comment.
@Balandat has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
facebook-github-bot
pushed a commit
that referenced
this pull request
Apr 25, 2019
Summary: Pull Request resolved: facebook/Ax#20 Pull Request resolved: #55 Using the torch native SobolEngine makes things a lot simpler for botorch. ax still uses the cython SobolEngine for a lot of things outside torch land. Reviewed By: danielrjiang Differential Revision: D14946543 fbshipit-source-id: b2b0ea09a5ea7dc29ecb2a24e7ecdc279d168943
Balandat
added a commit
that referenced
this pull request
Apr 26, 2019
Summary: Adds mathjax support. Clone of D14490827, see summary/test plan there. Pull Request resolved: #20 Reviewed By: sdaulton Differential Revision: D14494350 Pulled By: Balandat fbshipit-source-id: 6a72aa6464944f06d3b4a2c703bec7bfb9d85fed
Balandat
added a commit
that referenced
this pull request
Apr 26, 2019
Summary: Pull Request resolved: facebook/Ax#20 Pull Request resolved: #55 Using the torch native SobolEngine makes things a lot simpler for botorch. ax still uses the cython SobolEngine for a lot of things outside torch land. Reviewed By: danielrjiang Differential Revision: D14946543 fbshipit-source-id: b2b0ea09a5ea7dc29ecb2a24e7ecdc279d168943
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds mathjax support