Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjustments to setup.py and README for torch Sobol (#55) #20

Closed
wants to merge 1 commit into from
Closed

Adjustments to setup.py and README for torch Sobol (#55) #20

wants to merge 1 commit into from

Conversation

Balandat
Copy link
Contributor

Summary:
Pull Request resolved: pytorch/botorch#55

Using the torch native SobolEngine makes things a lot simpler for botorch.
ax still uses the cython SobolEngine for a lot of things outside torch land.

Reviewed By: danielrjiang

Differential Revision: D14946543

Summary:
Pull Request resolved: pytorch/botorch#55

Using the torch native SobolEngine makes things a lot simpler for botorch.
ax still uses the cython SobolEngine for a lot of things outside torch land.

Reviewed By: danielrjiang

Differential Revision: D14946543

fbshipit-source-id: c9f87b4900eba012a9320c42da6e1c12957b2bed
@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Apr 24, 2019
@Balandat
Copy link
Contributor Author

Anyone has any idea why this is failing with the following? Seems totally unrelated. Maybe an infra failure? Will rerun

pip 19.0.3 from /home/travis/virtualenv/python3.7.1/lib/python3.7/site-packages/pip (python 3.7)
0.01s$ openssl aes-256-cbc -K $encrypted_39ecd60da1dc_key -iv $encrypted_39ecd60da1dc_iv -in botorch_key.enc -out botorch_key -d
iv undefined
The command "openssl aes-256-cbc -K $encrypted_39ecd60da1dc_key -iv $encrypted_39ecd60da1dc_iv -in botorch_key.enc -out botorch_key -d" failed and exited with 1 during .

@Balandat
Copy link
Contributor Author

Oh I see I cut off the message too early - the encrypted environment variable is not available since this PR came from a fork .... not sure it's worth figuring out how to fix this since things will be made public soon anyway. I'll send a throwaway pr from the actual repo for testing onluy

facebook-github-bot pushed a commit to pytorch/botorch that referenced this pull request Apr 25, 2019
Summary:
Pull Request resolved: facebook/Ax#20

Pull Request resolved: #55

Using the torch native SobolEngine makes things a lot simpler for botorch.
ax still uses the cython SobolEngine for a lot of things outside torch land.

Reviewed By: danielrjiang

Differential Revision: D14946543

fbshipit-source-id: b2b0ea09a5ea7dc29ecb2a24e7ecdc279d168943
@facebook-github-bot
Copy link
Contributor

This pull request has been merged in 1fefa18.

Balandat added a commit to pytorch/botorch that referenced this pull request Apr 26, 2019
Summary:
Pull Request resolved: facebook/Ax#20

Pull Request resolved: #55

Using the torch native SobolEngine makes things a lot simpler for botorch.
ax still uses the cython SobolEngine for a lot of things outside torch land.

Reviewed By: danielrjiang

Differential Revision: D14946543

fbshipit-source-id: b2b0ea09a5ea7dc29ecb2a24e7ecdc279d168943
@Balandat Balandat deleted the export-D14946543 branch April 28, 2019 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Do not delete this pull request or issue due to inactivity.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants