Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable failing GPU unit test #3384

Closed
wants to merge 6 commits into from
Closed

Conversation

atalman
Copy link
Contributor

@atalman atalman commented May 29, 2023

Disable failing GPU unit test.
See associated issue: #3376

@pytorch-bot
Copy link

pytorch-bot bot commented May 29, 2023

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/audio/3384

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure

As of commit 233e462:

NEW FAILURE - The following job has failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@mthrok
Copy link
Collaborator

mthrok commented May 29, 2023

Thanks for looking into this.

Instead of disabling each of them, can we introduce a common decorator and environment variable so that when we want to check which one is temporary disabled, we can just flip the env var in CI and see which one fails?

https://github.com/pytorch/audio/blob/main/test/torchaudio_unittest/common_utils/case_utils.py#L280-L284

disabledInCI = _skipIf(
    "CI" in os.environ,
    reason="Tests are failing on CI consistently. Disabled while investigating.",
    key="TEMPORARY_DISABLED",
)

and

export TORCHAUDIO_TEST_ALLOW_SKIP_IF_ TEMPORARY_DISABLED=1

This will skip those decorated with disabledInCI in CI, but will fail in local env.

@atalman atalman force-pushed the unit_test_win_gpu branch from 4bf493c to 233e462 Compare May 30, 2023 13:08
@facebook-github-bot
Copy link
Contributor

@atalman has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@atalman merged this pull request in caf3ac0.

@github-actions
Copy link

Hey @atalman.
You merged this PR, but labels were not properly added. Please add a primary and secondary label (See https://github.com/pytorch/audio/blob/main/.github/process_commit.py).


Some guidance:

Use 'module: ops' for operations under 'torchaudio/{transforms, functional}', and ML-related components under 'torchaudio/csrc' (e.g. RNN-T loss).

Things in "examples" directory:

  • 'recipe' is applicable to training recipes under the 'examples' folder,
  • 'tutorial' is applicable to tutorials under the “examples/tutorials” folder
  • 'example' is applicable to everything else (e.g. C++ examples)
  • 'module: docs' is applicable to code documentations (not to tutorials).
    Regarding examples in code documentations, please also use 'module: docs'.

Please use 'other' tag only when you’re sure the changes are not much relevant to users, or when all other tags are not applicable. Try not to use it often, in order to minimize efforts required when we prepare release notes.


When preparing release notes, please make sure 'documentation' and 'tutorials' occur as the last sub-categories under each primary category like 'new feature', 'improvements' or 'prototype'.

Things related to build are by default excluded from the release note, except when it impacts users. For example:
* Drop support of Python 3.7.
* Add support of Python 3.X.
* Change the way a third party library is bound (so that user needs to install it separately).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants