-
Notifications
You must be signed in to change notification settings - Fork 672
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable failing GPU unit test #3384
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/audio/3384
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New FailureAs of commit 233e462: This comment was automatically generated by Dr. CI and updates every 15 minutes. |
Thanks for looking into this. Instead of disabling each of them, can we introduce a common decorator and environment variable so that when we want to check which one is temporary disabled, we can just flip the env var in CI and see which one fails?
and
This will skip those decorated with |
4bf493c
to
233e462
Compare
@atalman has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Hey @atalman. Some guidance:Use 'module: ops' for operations under 'torchaudio/{transforms, functional}', and ML-related components under 'torchaudio/csrc' (e.g. RNN-T loss). Things in "examples" directory:
Please use 'other' tag only when you’re sure the changes are not much relevant to users, or when all other tags are not applicable. Try not to use it often, in order to minimize efforts required when we prepare release notes. When preparing release notes, please make sure 'documentation' and 'tutorials' occur as the last sub-categories under each primary category like 'new feature', 'improvements' or 'prototype'. Things related to build are by default excluded from the release note, except when it impacts users. For example: |
Disable failing GPU unit test.
See associated issue: #3376