Skip to content

Commit

Permalink
Disable failing GPU unit test (#3384)
Browse files Browse the repository at this point in the history
Summary:
Disable failing GPU unit test.
See associated issue: #3376

Pull Request resolved: #3384

Reviewed By: mthrok

Differential Revision: D46279324

Pulled By: atalman

fbshipit-source-id: 3a606bb992e0261451f48d1fb458e054f7fd5583
  • Loading branch information
atalman authored and facebook-github-bot committed May 30, 2023
1 parent 9cdf26f commit caf3ac0
Show file tree
Hide file tree
Showing 8 changed files with 26 additions and 2 deletions.
2 changes: 2 additions & 0 deletions .circleci/config.yml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 2 additions & 0 deletions .circleci/config.yml.in
Original file line number Diff line number Diff line change
Expand Up @@ -355,6 +355,8 @@ jobs:
TORCHAUDIO_TEST_ALLOW_SKIP_IF_CUDA_SMALL_MEMORY: true
TORCHAUDIO_TEST_ALLOW_SKIP_IF_NO_AUDIO_OUT_DEVICE: true
TORCHAUDIO_TEST_ALLOW_SKIP_IF_NO_MACOS: true
TORCHAUDIO_TEST_ALLOW_SKIP_IF_TEMPORARY_DISABLED: true

- store_test_results:
path: test-results
- store_artifacts:
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/unittest-linux-gpu.yml
Original file line number Diff line number Diff line change
Expand Up @@ -74,6 +74,7 @@ jobs:
export TORCHAUDIO_TEST_ALLOW_SKIP_IF_CUDA_SMALL_MEMORY=true
export TORCHAUDIO_TEST_ALLOW_SKIP_IF_NO_HW_ACCEL=true
export TORCHAUDIO_TEST_ALLOW_SKIP_IF_ON_PYTHON_310=true
export TORCHAUDIO_TEST_ALLOW_SKIP_IF_TEMPORARY_DISABLED=true
declare -a args=(
'-v'
Expand Down
2 changes: 2 additions & 0 deletions test/torchaudio_unittest/common_utils/__init__.py
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
from .autograd_utils import use_deterministic_algorithms
from .backend_utils import set_audio_backend
from .case_utils import (
disabledInCI,
HttpServerMixin,
is_ffmpeg_available,
PytorchTestCase,
Expand Down Expand Up @@ -60,6 +61,7 @@
"skipIfNoFFmpeg",
"skipIfNoHWAccel",
"skipIfPy310",
"disabledInCI",
"get_wav_data",
"normalize_wav",
"load_wav",
Expand Down
5 changes: 5 additions & 0 deletions test/torchaudio_unittest/common_utils/case_utils.py
Original file line number Diff line number Diff line change
Expand Up @@ -287,6 +287,11 @@ def skipIfNoModule(module, display_name=None):
reason="This feature is only available for MacOS.",
key="NO_MACOS",
)
disabledInCI = _skipIf(
"CI" in os.environ,
reason="Tests are failing on CI consistently. Disabled while investigating.",
key="TEMPORARY_DISABLED",
)


def skipIfNoHWAccel(name):
Expand Down
3 changes: 3 additions & 0 deletions test/torchaudio_unittest/io/stream_reader_test.py
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
import torchaudio
from parameterized import parameterized, parameterized_class
from torchaudio_unittest.common_utils import (
disabledInCI,
get_asset_path,
get_image,
get_sinusoid,
Expand Down Expand Up @@ -1171,6 +1172,8 @@ def test_hevc_cuvid_hw_accel(self):


@skipIfNoHWAccel("h264_cuvid")
# Disabled in CI: https://github.com/pytorch/audio/issues/3376
@disabledInCI
class FilterGraphWithCudaAccel(TorchaudioTestCase):
def test_sclae_cuda_change_size(self):
"""scale_cuda filter can be used when HW accel is on"""
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
conformer_wav2vec2_pretrain_base,
conformer_wav2vec2_pretrain_large,
)
from torchaudio_unittest.common_utils import nested_params, skipIfNoCuda, torch_script, TorchaudioTestCase
from torchaudio_unittest.common_utils import disabledInCI, nested_params, skipIfNoCuda, torch_script, TorchaudioTestCase


class TestConformerWav2Vec2(TorchaudioTestCase):
Expand Down Expand Up @@ -33,6 +33,8 @@ def test_cpu_smoke_test(self, dtype):

@parameterized.expand([(torch.float32,), (torch.float64,)])
@skipIfNoCuda
# Disabled in CI: https://github.com/pytorch/audio/issues/3376
@disabledInCI
def test_cuda_smoke_test(self, dtype):
model = conformer_wav2vec2_base()
self._smoke_test(model, torch.device("cuda"), dtype)
Expand All @@ -50,6 +52,8 @@ def test_pretrain_cpu_smoke_test(self, model, dtype):
[torch.float32, torch.float64],
)
@skipIfNoCuda
# Disabled in CI: https://github.com/pytorch/audio/issues/3376
@disabledInCI
def test_pretrain_cuda_smoke_test(self, model, dtype):
model = model()
self._smoke_test(model, torch.device("cuda"), dtype)
Expand Down
7 changes: 6 additions & 1 deletion test/torchaudio_unittest/prototype/ssl_model_test.py
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,12 @@ def test_cpu_smoke_test(self, model_feature_dim, dtype):
self._smoke_test(model, feature_dim, torch.device("cpu"), dtype)

@nested_params(
[(conformer_wav2vec2_base, 64), (conformer_wav2vec2_pretrain_base, 64), (emformer_hubert_base, 80)],
[
(conformer_wav2vec2_base, 64),
# Skip since failing see issue: https://github.com/pytorch/audio/issues/3376
# (conformer_wav2vec2_pretrain_base, 64),
(emformer_hubert_base, 80),
],
[torch.float32, torch.float64],
)
@skipIfNoCuda
Expand Down

0 comments on commit caf3ac0

Please sign in to comment.