Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use rtd config file with htmldir builder #789

Merged
merged 7 commits into from
Jan 27, 2022
Merged

Conversation

hugovk
Copy link
Member

@hugovk hugovk commented Jan 7, 2022

Updates and closes #493.
Replaces and closes #784.

This adds the newline as requested in #493 and makes some other updates:

@hugovk
Copy link
Member Author

hugovk commented Jan 7, 2022

Error
Problem in your project's configuration. Invalid "build.tools.python": .readthedocs.yml: Invalid configuration option: build.tools.python. Make sure the key name is correct.

https://readthedocs.org/projects/cpython-devguide/builds/15708889/

Will check!

@hugovk hugovk marked this pull request as draft January 7, 2022 17:46
@hugovk
Copy link
Member Author

hugovk commented Jan 7, 2022

build.os was missing and is required.

Now passing and building. Also rebased to use the updated theme:

And update Sphinx to be able to use Python 3.10:

And let's update Sphinx and Furo whilst we're at it.

@hugovk hugovk marked this pull request as ready for review January 7, 2022 20:12
@zware
Copy link
Member

zware commented Jan 27, 2022

With @JulienPalard having already approved #493 and the build looking fine to me, merging.

@zware zware merged commit bff20d4 into python:main Jan 27, 2022
@hugovk hugovk deleted the rtd-build-v2b branch January 27, 2022 20:51
AA-Turner pushed a commit to AA-Turner/devguide that referenced this pull request Jun 17, 2022
* Python 3.10 requires newer Sphinx

* Update Furo

Co-authored-by: Carol Willing <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants