Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use rtd config file with htmldir builder #493

Closed
wants to merge 1 commit into from

Conversation

willingc
Copy link
Collaborator

@willingc willingc commented Jun 9, 2019

This PR is a follow-up to #481 and the redirect issue in #483.

This adds the ReadTheDocs configuration file which is the preferred build method for RTD.

Unlike #481, this PR specifies that the sphinx builder should user dirhtml instead of the default html. Reference in Sphinx docs

@JulienPalard, would you mind doing the review on this? Happy to answer any specific questions about it. Thanks.

@willingc
Copy link
Collaborator Author

willingc commented Jun 9, 2019

@JulienPalard I also made you a maintainer of the devguide in ReadTheDocs.

@JulienPalard
Copy link
Member

LGTM with nits: Can you add a newline at end of file?

@willingc willingc added the needs: PR update An update or rebase to an existing PR is needed. label Oct 19, 2020
@hugovk
Copy link
Member

hugovk commented Jan 7, 2022

Please see PR #789 to update this one and replace some deprecated options.

@hugovk
Copy link
Member

hugovk commented Jan 27, 2022

Closing in favour of #789. Reviews requested over there, thanks!

@hugovk hugovk closed this Jan 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA signed needs: PR update An update or rebase to an existing PR is needed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants